NEW 32894
[bzt] land-diff shouldn't stat the file system four times 
https://bugs.webkit.org/show_bug.cgi?id=32894
Summary [bzt] land-diff shouldn't stat the file system four times
Adam Barth
Reported 2009-12-23 00:33:14 PST
land-diff shouldn't stat the file system four times. That's really too many. :0
Attachments
Patch (3.18 KB, patch)
2009-12-23 00:34 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-23 00:34:21 PST
Created attachment 45423 [details] Patch
Adam Barth
Comment 2 2009-12-23 00:35:14 PST
Comment on attachment 45423 [details] Patch I'm not sure this is the right approach. The problem is not all clients of SCM will want to see a stale version of changed_files. Also, this change breaks one of the SCM unit tests for this reason.
Eric Seidel (no email)
Comment 3 2009-12-23 13:00:48 PST
Comment on attachment 45423 [details] Patch This seems like a bad idea: if length > 31000: 331 # We're risking exceeding the 32k length limit on Windows. 332 return [] I'm not even sure what ou're tring to avoid, but I would expect returing [] w/o exception is bad.
Note You need to log in before you can comment on or make changes to this bug.