Bug 32893 - [bzt] Don't call create-patch twice during post-diff
Summary: [bzt] Don't call create-patch twice during post-diff
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-22 23:54 PST by Adam Barth
Modified: 2009-12-27 15:40 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.36 KB, patch)
2009-12-22 23:55 PST, Adam Barth
mjs: review+
Details | Formatted Diff | Diff
Patch (2.36 KB, patch)
2009-12-22 23:56 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (168.44 KB, patch)
2009-12-27 03:01 PST, Maciej Stachowiak
no flags Details | Formatted Diff | Diff
Patch (167.12 KB, patch)
2009-12-27 15:36 PST, Maciej Stachowiak
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-22 23:54:14 PST
Don't call create-patch twice during post-diff.  It's slow.
Comment 1 Adam Barth 2009-12-22 23:55:38 PST
Created attachment 45421 [details]
Patch
Comment 2 Adam Barth 2009-12-22 23:56:42 PST
Created attachment 45422 [details]
Patch
Comment 3 WebKit Review Bot 2009-12-22 23:57:03 PST
style-queue ran check-webkit-style on attachment 45422 [details] without any errors.
Comment 4 Maciej Stachowiak 2009-12-22 23:57:21 PST
Comment on attachment 45421 [details]
Patch

r=me
Comment 5 Maciej Stachowiak 2009-12-22 23:59:39 PST
Comment on attachment 45422 [details]
Patch

again - r=me
Comment 6 Adam Barth 2009-12-23 00:42:37 PST
http://trac.webkit.org/changeset/52523
Comment 7 Eric Seidel (no email) 2009-12-23 12:53:46 PST
Comment on attachment 45422 [details]
Patch

I wonder if we shouldn't cache this off of scm instead?  Not sure.  Manually storing/retrieving it from state seems odd.
Comment 8 Eric Seidel (no email) 2009-12-23 12:54:37 PST
We really need some sort of test for these commands to validate that they don't call scm too much...
Comment 9 Adam Barth 2009-12-23 12:58:11 PST
There's a related patch for land-diff that tries caching in SCM.  It's unclear which is better.  I think it depends on what contract you think SCM is enforcing.
Comment 10 Maciej Stachowiak 2009-12-27 03:01:50 PST
Created attachment 45520 [details]
Patch
Comment 11 WebKit Review Bot 2009-12-27 03:06:37 PST
style-queue ran check-webkit-style on attachment 45520 [details] without any errors.
Comment 12 Adam Barth 2009-12-27 10:14:28 PST
Comment on attachment 45520 [details]
Patch

I think you might have posted this patch to the wrong bug...
Comment 13 Maciej Stachowiak 2009-12-27 15:36:53 PST
Created attachment 45536 [details]
Patch
Comment 14 Maciej Stachowiak 2009-12-27 15:40:39 PST
Comment on attachment 45536 [details]
Patch

My fault, I still had some testing changes in my tree.