RESOLVED FIXED Bug 32893
[bzt] Don't call create-patch twice during post-diff 
https://bugs.webkit.org/show_bug.cgi?id=32893
Summary [bzt] Don't call create-patch twice during post-diff
Adam Barth
Reported 2009-12-22 23:54:14 PST
Don't call create-patch twice during post-diff. It's slow.
Attachments
Patch (2.36 KB, patch)
2009-12-22 23:55 PST, Adam Barth 		mjs: review+
DetailsFormatted DiffDiff
Patch (2.36 KB, patch)
2009-12-22 23:56 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (168.44 KB, patch)
2009-12-27 03:01 PST, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Patch (167.12 KB, patch)
2009-12-27 15:36 PST, Maciej Stachowiak 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-22 23:55:38 PST
Created attachment 45421 [details] Patch
Adam Barth
Comment 2 2009-12-22 23:56:42 PST
Created attachment 45422 [details] Patch
WebKit Review Bot
Comment 3 2009-12-22 23:57:03 PST
style-queue ran check-webkit-style on attachment 45422 [details] without any errors.
Maciej Stachowiak
Comment 4 2009-12-22 23:57:21 PST
Comment on attachment 45421 [details] Patch r=me
Maciej Stachowiak
Comment 5 2009-12-22 23:59:39 PST
Comment on attachment 45422 [details] Patch again - r=me
Adam Barth
Comment 6 2009-12-23 00:42:37 PST
http://trac.webkit.org/changeset/52523
Eric Seidel (no email)
Comment 7 2009-12-23 12:53:46 PST
Comment on attachment 45422 [details] Patch I wonder if we shouldn't cache this off of scm instead? Not sure. Manually storing/retrieving it from state seems odd.
Eric Seidel (no email)
Comment 8 2009-12-23 12:54:37 PST
We really need some sort of test for these commands to validate that they don't call scm too much...
Adam Barth
Comment 9 2009-12-23 12:58:11 PST
There's a related patch for land-diff that tries caching in SCM. It's unclear which is better. I think it depends on what contract you think SCM is enforcing.
Maciej Stachowiak
Comment 10 2009-12-27 03:01:50 PST
Created attachment 45520 [details] Patch
WebKit Review Bot
Comment 11 2009-12-27 03:06:37 PST
style-queue ran check-webkit-style on attachment 45520 [details] without any errors.
Adam Barth
Comment 12 2009-12-27 10:14:28 PST
Comment on attachment 45520 [details] Patch I think you might have posted this patch to the wrong bug...
Maciej Stachowiak
Comment 13 2009-12-27 15:36:53 PST
Created attachment 45536 [details] Patch
Maciej Stachowiak
Comment 14 2009-12-27 15:40:39 PST
Comment on attachment 45536 [details] Patch My fault, I still had some testing changes in my tree.
Note You need to log in before you can comment on or make changes to this bug.