[ 509/1814] cxx: JavaScriptCore\assembler\ARMAssembler.cpp -> build\default\JavaScriptCore\assembler\ARMAssembler_1.o "..\JavaScriptCore/jit/ExecutableAllocator.h", line 107: Error: #20: identifier "ptrdiff_t" is undefined if (static_cast<ptrdiff_t>(n) < (m_end - m_freePtr)) { ^ ..\JavaScriptCore\assembler\ARMAssembler.cpp: 0 warnings, 1 error In RVCT, ptrdiff_t is tyedefed in stddef.h, so we need to include stddef.h in JavaScriptCore/jit/ExecutableAllocator.h.
Created attachment 45413 [details] Include stddef.h
style-queue ran check-webkit-style on attachment 45413 [details] without any errors.
Comment on attachment 45413 [details] Include stddef.h This include should not be inside an if statement. We should add <stddef.h> unconditionally for all compilers. It should be added to the main paragraph of includes at the top of the file.
Created attachment 45420 [details] Include stddef.h for ptrdiff_t without compiler guards
style-queue ran check-webkit-style on attachment 45420 [details] without any errors.
Comment on attachment 45420 [details] Include stddef.h for ptrdiff_t without compiler guards Looks good, r=me
Comment on attachment 45420 [details] Include stddef.h for ptrdiff_t without compiler guards Rejecting patch 45420 from review queue. laszlo.1.gombos@nokia.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have reviewer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the reviewer flag again. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
Comment on attachment 45420 [details] Include stddef.h for ptrdiff_t without compiler guards Try again, after I added myself to the reviewers list - http://trac.webkit.org/changeset/52531.
hmm.. Maybe I wait a bit more to let the Commit Bot pick up the change.
> hmm.. Maybe I wait a bit more to let the Commit Bot pick up the change. The commit bot won't land this because it's marked review-. You'll need to get a reviewer to change that flag to review+ first.
Sorry. Due to bug 30084 the commit-queue does not immediately notice changes to committers.py. I have filed bug 32911 as a workaround until bug 30084 can be fixed. Sorry again for the confusion. The commit-queue has been restarted and will now recognize your r+ correctly.
Comment on attachment 45420 [details] Include stddef.h for ptrdiff_t without compiler guards Thanks Eric.
Comment on attachment 45420 [details] Include stddef.h for ptrdiff_t without compiler guards Clearing flags on attachment: 45420 Committed r52538: <http://trac.webkit.org/changeset/52538>
All reviewed patches have been landed. Closing bug.