Bug 32877 - [GTK] confirm dialog should show OK/Cancel instead of Yes/No for consistency
Summary: [GTK] confirm dialog should show OK/Cancel instead of Yes/No for consistency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-22 12:28 PST by Grant Gayed
Modified: 2010-08-25 18:39 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.05 KB, patch)
2010-08-20 20:25 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed 2009-12-22 12:28:16 PST
- using WebKitGTK 1.1.16 built from source on Ubuntu 9.10

Every other Browser I have access to, including Safari, labels the buttons in javascript confirm prompters as OK/Cancel, but WebKitGTK labels them Yes/No.  I realize that there may not be a "correct" set of buttons spec'd for this type of prompter, but since all of the other Browsers are using OK/Cancel, there are JS authors that word their confirm messages accordingly (this is how I noticed this difference).
Comment 1 Martin Robinson 2010-08-20 20:22:00 PDT
This is the fallback dialog, so this change would be pretty safe. I'm not sure how others feel about this, but I'm attaching a patch. If others dislike the change we can close the bug.
Comment 2 Martin Robinson 2010-08-20 20:25:44 PDT
Created attachment 65018 [details]
Patch
Comment 3 Gustavo Noronha (kov) 2010-08-25 11:00:37 PDT
Comment on attachment 65018 [details]
Patch

I do think it makes a lot of sense to use the commonly used terms.
Comment 4 Martin Robinson 2010-08-25 18:39:41 PDT
Comment on attachment 65018 [details]
Patch

Clearing flags on attachment: 65018

Committed r66070: <http://trac.webkit.org/changeset/66070>
Comment 5 Martin Robinson 2010-08-25 18:39:45 PDT
All reviewed patches have been landed.  Closing bug.