RESOLVED FIXED Bug 32869
Web Inspector: simplify highlighters definition. 
https://bugs.webkit.org/show_bug.cgi?id=32869
Summary Web Inspector: simplify highlighters definition.
Pavel Feldman
Reported 2009-12-22 07:37:29 PST
I was experimenting with canvas-based source rendering and came across some unnecessary highlighter complexities.
Attachments
[PATCH] Proposed change (68.47 KB, patch)
2009-12-22 07:38 PST, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-12-22 07:38:51 PST
Created attachment 45384 [details] [PATCH] Proposed change
WebKit Review Bot
Comment 2 2009-12-22 07:43:52 PST
style-queue ran check-webkit-style on attachment 45384 [details] without any errors.
Timothy Hatcher
Comment 3 2009-12-22 10:41:26 PST
Comment on attachment 45384 [details] [PATCH] Proposed change > + ].keySet(); > + > + const valueKeywords = [ 2 space indent infront of ].keySet(). Nice clean up!
Pavel Feldman
Comment 4 2009-12-22 12:10:13 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/syntax-highlight-css-expected.txt M LayoutTests/inspector/syntax-highlight-javascript-expected.txt M LayoutTests/inspector/syntax-highlight.js M WebCore/ChangeLog M WebCore/inspector/front-end/CSSSourceSyntaxHighlighter.js M WebCore/inspector/front-end/JavaScriptSourceSyntaxHighlighter.js M WebCore/inspector/front-end/SourceSyntaxHighlighter.js M WebCore/inspector/front-end/utilities.js Committed r52495
Note You need to log in before you can comment on or make changes to this bug.