Bug 32869 - Web Inspector: simplify highlighters definition.
Summary: Web Inspector: simplify highlighters definition.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2009-12-22 07:37 PST by Pavel Feldman
Modified: 2009-12-22 12:10 PST (History)
5 users (show)

See Also:

[PATCH] Proposed change (68.47 KB, patch)
2009-12-22 07:38 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-12-22 07:37:29 PST
I was experimenting with canvas-based source rendering and came across some unnecessary highlighter complexities.
Comment 1 Pavel Feldman 2009-12-22 07:38:51 PST
Created attachment 45384 [details]
[PATCH] Proposed change
Comment 2 WebKit Review Bot 2009-12-22 07:43:52 PST
style-queue ran check-webkit-style on attachment 45384 [details] without any errors.
Comment 3 Timothy Hatcher 2009-12-22 10:41:26 PST
Comment on attachment 45384 [details]
[PATCH] Proposed change

> +      ].keySet();
> +    
> +    const valueKeywords = [

2 space indent infront of ].keySet().

Nice clean up!
Comment 4 Pavel Feldman 2009-12-22 12:10:13 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/syntax-highlight-css-expected.txt
	M	LayoutTests/inspector/syntax-highlight-javascript-expected.txt
	M	LayoutTests/inspector/syntax-highlight.js
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/CSSSourceSyntaxHighlighter.js
	M	WebCore/inspector/front-end/JavaScriptSourceSyntaxHighlighter.js
	M	WebCore/inspector/front-end/SourceSyntaxHighlighter.js
	M	WebCore/inspector/front-end/utilities.js
Committed r52495