WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32853
Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to __forceinline for RVCT
https://bugs.webkit.org/show_bug.cgi?id=32853
Summary
Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to __forceinline for RVCT
Kwang Yul Seo
Reported
2009-12-21 23:33:25 PST
In RVCT, __forceinline forces the compiler to compile a C or C++ function inline. The compiler attempts to inline the function, regardless of the characteristics of the function. I see no real performance gains in SunSpider after applying this patch, but I think being explicit about the intention is good.
Attachments
Use __forceinline to force RVCT to inline functions.
(1.91 KB, patch)
2009-12-21 23:36 PST
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2009-12-21 23:36:41 PST
Created
attachment 45367
[details]
Use __forceinline to force RVCT to inline functions.
WebKit Review Bot
Comment 2
2009-12-21 23:40:39 PST
Attachment 45367
[details]
did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/AlwaysInline.h:26: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1
WebKit Commit Bot
Comment 3
2009-12-22 10:36:48 PST
Comment on
attachment 45367
[details]
Use __forceinline to force RVCT to inline functions. Clearing flags on attachment: 45367 Committed
r52490
: <
http://trac.webkit.org/changeset/52490
>
WebKit Commit Bot
Comment 4
2009-12-22 10:36:53 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug