Bug 32853 - Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to __forceinline for RVCT
Summary: Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to __forceinline for RVCT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-21 23:33 PST by Kwang Yul Seo
Modified: 2009-12-22 10:36 PST (History)
2 users (show)

See Also:

Attachments
Use __forceinline to force RVCT to inline functions. (1.91 KB, patch)
2009-12-21 23:36 PST, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2009-12-21 23:33:25 PST 
In RVCT, __forceinline forces the compiler to compile a C or C++ function inline.  The compiler attempts to inline the function, regardless of the characteristics of the function.

I see no real performance gains in SunSpider after applying this patch, but I think being explicit about the intention is good.
Comment 1 Kwang Yul Seo 2009-12-21 23:36:41 PST 
Created attachment 45367 [details]
Use __forceinline to force RVCT to inline functions.
Comment 2 WebKit Review Bot 2009-12-21 23:40:39 PST 
Attachment 45367 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/AlwaysInline.h:26:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1
Comment 3 WebKit Commit Bot 2009-12-22 10:36:48 PST 
Comment on attachment 45367 [details]
Use __forceinline to force RVCT to inline functions.

Clearing flags on attachment: 45367

Committed r52490: <http://trac.webkit.org/changeset/52490>
Comment 4 WebKit Commit Bot 2009-12-22 10:36:53 PST 
All reviewed patches have been landed.  Closing bug.