Bug 32844 - [V8] Generate header declaration for property accessor getters/setters
Summary: [V8] Generate header declaration for property accessor getters/setters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks: 32638
  Show dependency treegraph
 
Reported: 2009-12-21 16:20 PST by Nate Chapin
Modified: 2009-12-30 14:14 PST (History)
1 user (show)

See Also:


Attachments
Generate property accessor getter/setter declarations. (46.43 KB, patch)
2009-12-21 16:29 PST, Nate Chapin
dglazkov: review+
Details | Formatted Diff | Diff
patch2 - removed .idl modifications (47.39 KB, patch)
2009-12-30 13:36 PST, Nate Chapin
dglazkov: review+
japhet: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2009-12-21 16:20:57 PST
Part of https://bugs.webkit.org/show_bug.cgi?id=32638, the quest to remove all the manually declared custom bindings from V8CustomBinding.h.
Comment 1 Nate Chapin 2009-12-21 16:29:08 PST
Created attachment 45359 [details]
Generate property accessor getter/setter declarations.

I'm on my way out the door for the holidays, so this review is decidedly non-urgent.
Comment 2 WebKit Review Bot 2009-12-21 16:33:56 PST
style-queue ran check-webkit-style on attachment 45359 [details] without any errors.
Comment 3 Dimitri Glazkov (Google) 2009-12-29 09:08:29 PST
Comment on attachment 45359 [details]
Generate property accessor getter/setter declarations.

r=me with notes:

Gah! Why is this custom for V8 bindings? Need a FIXME and a bug for this.

> +        readonly attribute [V8CustomGetter] DOMString appVersion;

Ditto.

> +                 attribute [Replaceable, V8CustomGetter] WorkerContext self;

This special-casing bonanza needs FIXMEs and bugs. We should work to remove these.

> +    if ($dataNode->name eq "Event") {
> +        push(@headerContent, "  static v8::Handle<v8::Value> dataTransferAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
> +        push(@headerContent, "  static void valueAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info);\n");
> +    }
> +    if ($dataNode->name eq "Location") {
> +        push(@headerContent, "  static v8::Handle<v8::Value> assignAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
> +        push(@headerContent, "  static v8::Handle<v8::Value> reloadAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
> +        push(@headerContent, "  static v8::Handle<v8::Value> replaceAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
> +    }
>  }
Comment 4 Nate Chapin 2009-12-30 13:36:31 PST
Created attachment 45683 [details]
patch2 - removed .idl modifications

The .idl modifications were originally necessary because of some v8 only custom bindings that didn't really need to be custom.  Those bindings are now generated, which resulted in the removal of V8NavigatorCustom.cpp.
Comment 5 WebKit Review Bot 2009-12-30 13:36:56 PST
style-queue ran check-webkit-style on attachment 45683 [details] without any errors.
Comment 6 Dimitri Glazkov (Google) 2009-12-30 13:39:58 PST
Comment on attachment 45683 [details]
patch2 - removed .idl modifications

ROCK!
Comment 7 Nate Chapin 2009-12-30 14:14:29 PST
http://trac.webkit.org/changeset/52672