Bug 32841 – [Chromium] Adding new methods to the Chromium DOM API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Jay Campan]

Created attachment 45350 [details]
Adding some extra methods to the Chromium DOM API (needed for the translate feature)

Adding new methods to the Chromium DOM API.
There are needed by the upcoming translate feature.

[WebKit Review Bot]

Attachment 45350 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebNode.cpp:90:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1

[Eric Seidel (no email)]

Darin or Dimitry is your best bet.  Also there is a style error in the patch.

[Jay Campan]

Created attachment 45389 [details]
45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature)

Fixing style issue.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45389 [details] without any errors.

[Adam Barth]

Looks sane to me, but Darin is the arbiter of the API.

[Darin Fisher (:fishd, Google)]

Comment on attachment 45389 [details]
45350: Adding some extra methods to the Chromium DOM API (needed for the translate feature)

> Index: WebKit/chromium/src/WebElement.cpp
...
> +WebString WebElement::getTagName() const
> +{
> +    return constUnwrap<Element>()->tagName();

Please change WebElement::getTagName to just tagName.  WebKit
style avoids "get"

Otherwise, LGTM

-Darin

[Jay Campan]

Created attachment 45812 [details]
Changed WebElement::getTagName() to WebElement::tagName()

[Jay Campan]

Created attachment 45813 [details]
Changed WebElement::getTagName() to WebElement::tagName()

[WebKit Commit Bot]

Comment on attachment 45813 [details]
Changed WebElement::getTagName() to WebElement::tagName()

Clearing flags on attachment: 45813

Committed r52774: <http://trac.webkit.org/changeset/52774>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.