Bug 32824 – [WINCE] Buildfix for MemoryManager.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Patrick R. Gansterer]

Created attachment 45328 [details]
WinCE buildfix

r47092 introduced TryMallocReturnValue, but didn't changed it in the WinCE port.

[WebKit Commit Bot]

Comment on attachment 45328 [details]
WinCE buildfix

Rejecting patch 45328 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1
Last 500 characters of output:
d at 1 with fuzz 3.
(Stripping trailing CRs from patch.)
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: wtf/wince/MemoryManager.cpp
|===================================================================
|--- wtf/wince/MemoryManager.cpp	(revision 52427)
|+++ wtf/wince/MemoryManager.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Full output: http://webkit-commit-queue.appspot.com/results/143141

[Eric Seidel (no email)]

Looks like the patch was made from an incomplete checkout.  The commit-queue can only handle patches made from complete checkouts, as then our scripts (svn-create-patch) will know how to create patches with full paths.

[Patrick R. Gansterer]

Created attachment 45428 [details]
corrected patch

[WebKit Commit Bot]

Comment on attachment 45428 [details]
corrected patch

Rejecting patch 45428 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the reviewer flag again.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

[Eric Seidel (no email)]

Comment on attachment 45428 [details]
corrected patch

Looks OK.  I'm shocked that the wince build has been broken for 5000 revisions.

the commit-queue will reject your cq+ as well, you'd need to set that to commit-queue=? instead.  I'll clear it and then set it to cq+.

[Eric Seidel (no email)]

Thanks again for the fix!

[Patrick R. Gansterer]

(In reply to comment #5)
> (From update of attachment 45428 [details])
> Looks OK.  I'm shocked that the wince build has been broken for 5000 revisions.
The WinCE port isn't finished and i don't see any progress.
I think that the main problem is the missing buildsystem. I'd like to commit one, but i'm not sure about the prefered solution. Currently i prefere to extend the sln/vcproj/vsprops system. Is there already some information about that or should i ask at webkit-dev?

[WebKit Commit Bot]

Comment on attachment 45428 [details]
corrected patch

Clearing flags on attachment: 45428

Committed r52529: <http://trac.webkit.org/changeset/52529>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

GYP is the latest fashion http://code.google.com/p/gyp/
Whether that's a good solution for the WinCE port or not, I do not know.