Bug 32817 - [Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image
: [Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of...
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: PC All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-12-21 00:43 PST by
Modified: 2009-12-23 18:23 PST (History)


Attachments
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image. (1.92 KB, patch)
2009-12-21 01:18 PST, Yuta Kitamura
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-12-21 00:43:50 PST
PlatformContextSkia::beginLayerClippedToImage is supposed to limit the current painting window to the bounds of the given image, but it does not. This makes LayoutTests/svg/custom/mask-with-all-units.svg fail in the Chromium layout test.

Chromium issue: http://code.google.com/p/chromium/issues/detail?id=29056
------- Comment #1 From 2009-12-21 01:18:15 PST -------
Created an attachment (id=45314) [details]
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.
------- Comment #2 From 2009-12-21 01:21:49 PST -------
style-queue ran check-webkit-style on attachment 45314 [details] without any errors.
------- Comment #3 From 2009-12-23 16:26:50 PST -------
LGTM.

(I am not a WebKit reviewer. You need a real review before landing.)
------- Comment #4 From 2009-12-23 16:36:49 PST -------
(From update of attachment 45314 [details])
Thank you Adam.  LGTM too.
------- Comment #5 From 2009-12-23 18:23:48 PST -------
(From update of attachment 45314 [details])
Clearing flags on attachment: 45314

Committed r52539: <http://trac.webkit.org/changeset/52539>
------- Comment #6 From 2009-12-23 18:23:54 PST -------
All reviewed patches have been landed.  Closing bug.