Bug 32817 - [Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image
: [Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Platform
: 528+ (Nightly build)
: PC All
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-21 00:43 PST by Yuta Kitamura
Modified: 2009-12-23 18:23 PST (History)
6 users (show)

See Also:


Attachments
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image. (1.92 KB, patch)
2009-12-21 01:18 PST, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2009-12-21 00:43:50 PST
PlatformContextSkia::beginLayerClippedToImage is supposed to limit the current painting window to the bounds of the given image, but it does not. This makes LayoutTests/svg/custom/mask-with-all-units.svg fail in the Chromium layout test.

Chromium issue: http://code.google.com/p/chromium/issues/detail?id=29056
Comment 1 Yuta Kitamura 2009-12-21 01:18:15 PST
Created attachment 45314 [details]
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.
Comment 2 WebKit Review Bot 2009-12-21 01:21:49 PST
style-queue ran check-webkit-style on attachment 45314 [details] without any errors.
Comment 3 Adam Langley 2009-12-23 16:26:50 PST
LGTM.

(I am not a WebKit reviewer. You need a real review before landing.)
Comment 4 Eric Seidel 2009-12-23 16:36:49 PST
Comment on attachment 45314 [details]
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.

Thank you Adam.  LGTM too.
Comment 5 WebKit Commit Bot 2009-12-23 18:23:48 PST
Comment on attachment 45314 [details]
PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.

Clearing flags on attachment: 45314

Committed r52539: <http://trac.webkit.org/changeset/52539>
Comment 6 WebKit Commit Bot 2009-12-23 18:23:54 PST
All reviewed patches have been landed.  Closing bug.