Bug 32816 - [bzt] Automate the process of calling prepare-ChangeLog
Summary: [bzt] Automate the process of calling prepare-ChangeLog
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-21 00:36 PST by Adam Barth
Modified: 2009-12-21 22:47 PST (History)
3 users (show)

See Also:

Patch (13.77 KB, patch)
2009-12-21 00:38 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (13.55 KB, patch)
2009-12-21 00:41 PST, Adam Barth
eric: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-21 00:36:11 PST
We should start work on a submit-patch command that automates the process of creating a bug and uploading a code change.  In the first cut, I'm going to focus on calling prepare-ChangeLog.  I'll create the bug in a second round.
Comment 1 Adam Barth 2009-12-21 00:38:30 PST
Created attachment 45309 [details]
Comment 2 WebKit Review Bot 2009-12-21 00:40:13 PST
Attachment 45309 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/ChangeLog:17:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1
Comment 3 Adam Barth 2009-12-21 00:41:21 PST
Created attachment 45310 [details]
Comment 4 WebKit Review Bot 2009-12-21 00:45:32 PST
style-queue ran check-webkit-style on attachment 45310 [details] without any errors.
Comment 5 Eric Seidel (no email) 2009-12-21 22:38:40 PST
Comment on attachment 45310 [details]

I think the -o approach is strange, and probably wrong.   $EDITOR or some sort of user prompting is what we want in the end.

Also --non-interactive makes little sense for PrepareChangeLog, but ok.

The addition of SubmitPatch at this time doesn't seem much value add.  But the rest of the changes seem great!  (I'm OK keeping it around, just seems kinda vacuous atm.)

Clearly PostCommits needs to be converted too. :(

Comment 6 Adam Barth 2009-12-21 22:40:32 PST
Comment on attachment 45310 [details]

Comment 7 Adam Barth 2009-12-21 22:47:08 PST
Committed r52480: <http://trac.webkit.org/changeset/52480>