RESOLVED FIXED 32816
[bzt] Automate the process of calling prepare-ChangeLog 
https://bugs.webkit.org/show_bug.cgi?id=32816
Summary [bzt] Automate the process of calling prepare-ChangeLog
Adam Barth
Reported 2009-12-21 00:36:11 PST
We should start work on a submit-patch command that automates the process of creating a bug and uploading a code change. In the first cut, I'm going to focus on calling prepare-ChangeLog. I'll create the bug in a second round.
Attachments
Patch (13.77 KB, patch)
2009-12-21 00:38 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (13.55 KB, patch)
2009-12-21 00:41 PST, Adam Barth 		eric: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-21 00:38:30 PST
Created attachment 45309 [details] Patch
WebKit Review Bot
Comment 2 2009-12-21 00:40:13 PST
Attachment 45309 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/ChangeLog:17: Line contains tab character. [whitespace/tab] [5] Total errors found: 1
Adam Barth
Comment 3 2009-12-21 00:41:21 PST
Created attachment 45310 [details] Patch
WebKit Review Bot
Comment 4 2009-12-21 00:45:32 PST
style-queue ran check-webkit-style on attachment 45310 [details] without any errors.
Eric Seidel (no email)
Comment 5 2009-12-21 22:38:40 PST
Comment on attachment 45310 [details] Patch I think the -o approach is strange, and probably wrong. $EDITOR or some sort of user prompting is what we want in the end. Also --non-interactive makes little sense for PrepareChangeLog, but ok. The addition of SubmitPatch at this time doesn't seem much value add. But the rest of the changes seem great! (I'm OK keeping it around, just seems kinda vacuous atm.) Clearly PostCommits needs to be converted too. :( LGTM.
Adam Barth
Comment 6 2009-12-21 22:40:32 PST
Comment on attachment 45310 [details] Patch tahnks
Adam Barth
Comment 7 2009-12-21 22:47:08 PST
Committed r52480: <http://trac.webkit.org/changeset/52480>
Note You need to log in before you can comment on or make changes to this bug.