Bug 32815 - Detailed boundingBoxes in SVG Renderer
Summary: Detailed boundingBoxes in SVG Renderer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 525.x (Safari 3.1)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
: 33043 (view as bug list)
Depends on:
Blocks: 26231 30055 32584 32935
  Show dependency treegraph
 
Reported: 2009-12-21 00:12 PST by Dirk Schulze
Modified: 2009-12-30 00:58 PST (History)
4 users (show)

See Also:


Attachments
New bounding boxes for SVG (43.83 KB, patch)
2009-12-28 12:49 PST, Dirk Schulze
zimmermann: review+
Details | Formatted Diff | Diff
Updated LayoutTest results for new SVG boundingBoxes (292.37 KB, patch)
2009-12-28 12:50 PST, Dirk Schulze
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2009-12-21 00:12:41 PST
We need more detailed boundingBoxes in the SVG Renderer. That would help to minimize ImageBuffer sizes for Maskers, Filters, Patterns and would correct repaintRectInLocalCoordinates().
repaintRectInLocalCoordinates() is not useable at the moment, because it gives back wrong drawing rects.
Seperate boundingboxes of strokeRects, filterRects, maskRects, clipperRects, markerRects would be usefull.
Comment 1 Dirk Schulze 2009-12-28 12:49:29 PST
Created attachment 45570 [details]
New bounding boxes for SVG

New boundingboxes for masker, clipper, filter, marker and stroke were added, repaintRectInLocalCoordinates was fixed.
Comment 2 Dirk Schulze 2009-12-28 12:50:41 PST
Created attachment 45571 [details]
Updated LayoutTest results for new SVG boundingBoxes

Updated test results after the changes on repaintRectInLocalCoordinates.
Comment 3 WebKit Review Bot 2009-12-28 12:55:21 PST
style-queue ran check-webkit-style on attachment 45570 [details] without any errors.
Comment 4 WebKit Review Bot 2009-12-28 12:56:06 PST
style-queue ran check-webkit-style on attachment 45571 [details] without any errors.
Comment 5 Nikolas Zimmermann 2009-12-29 02:53:39 PST
Comment on attachment 45570 [details]
New bounding boxes for SVG

We have iterated this patch several times, looks fine. r=me.
Comment 6 Eric Seidel (no email) 2009-12-29 20:50:55 PST
Attachment 45571 [details] was posted by a committer and has review+, assigning to Dirk Schulze for commit.
Comment 7 Dirk Schulze 2009-12-29 23:39:57 PST
*** Bug 33043 has been marked as a duplicate of this bug. ***
Comment 8 Dirk Schulze 2009-12-30 00:58:53 PST
landed patch in r52647 and a forgotten LayoutTest result in r52749. Closing bug now.