RESOLVED FIXED 32803
Web Inspector: extract syntax highlighters into separate files. 
https://bugs.webkit.org/show_bug.cgi?id=32803
Summary Web Inspector: extract syntax highlighters into separate files.
Pavel Feldman
Reported 2009-12-20 13:48:04 PST
Otherwise SourceFrame is too big.
Attachments
[PATCH] Pure split, no other changes. (107.11 KB, patch)
2009-12-20 13:52 PST, Pavel Feldman 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-12-20 13:52:33 PST
Created attachment 45295 [details] [PATCH] Pure split, no other changes.
WebKit Review Bot
Comment 2 2009-12-20 13:53:46 PST
style-queue ran check-webkit-style on attachment 45295 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-20 15:07:35 PST
Comment on attachment 45295 [details] [PATCH] Pure split, no other changes. The big dictionaries all returnign "true" seem silly. They shoudl just be written as arrays but converted to dictionaries at runtime. If this is just moving code than rs=me.
Pavel Feldman
Comment 4 2009-12-21 03:00:47 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj A WebCore/inspector/front-end/CSSSourceSyntaxHighlighter.js A WebCore/inspector/front-end/JavaScriptSourceSyntaxHighlighter.js M WebCore/inspector/front-end/SourceFrame.js A WebCore/inspector/front-end/SourceSyntaxHighlighter.js M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.html Committed r52439
Note You need to log in before you can comment on or make changes to this bug.