WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32796
[check-webkit-style] static_cast is not misnamed!
https://bugs.webkit.org/show_bug.cgi?id=32796
Summary
[check-webkit-style] static_cast is not misnamed!
Adam Barth
Reported
2009-12-20 09:47:28 PST
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/qt/ThreadingQt.cpp:183: static_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1
https://bugs.webkit.org/show_bug.cgi?id=32614#c2
Attachments
Patch v1
(1.80 KB, patch)
2009-12-20 10:02 PST
,
Shinichiro Hamaji
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1
2009-12-20 10:02:41 PST
Created
attachment 45285
[details]
Patch v1
WebKit Review Bot
Comment 2
2009-12-20 10:04:16 PST
style-queue ran check-webkit-style on
attachment 45285
[details]
without any errors.
Adam Barth
Comment 3
2009-12-20 10:14:19 PST
Comment on
attachment 45285
[details]
Patch v1 LGTM!
WebKit Commit Bot
Comment 4
2009-12-20 10:22:19 PST
Comment on
attachment 45285
[details]
Patch v1 Clearing flags on attachment: 45285 Committed
r52423
: <
http://trac.webkit.org/changeset/52423
>
WebKit Commit Bot
Comment 5
2009-12-20 10:22:25 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug