Bug 32796 - [check-webkit-style] static_cast is not misnamed!
Summary: [check-webkit-style] static_cast is not misnamed!
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-20 09:47 PST by Adam Barth
Modified: 2009-12-20 10:22 PST (History)
6 users (show)

See Also:

Patch v1 (1.80 KB, patch)
2009-12-20 10:02 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-20 09:47:28 PST
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/qt/ThreadingQt.cpp:183:  static_cast is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1

Comment 1 Shinichiro Hamaji 2009-12-20 10:02:41 PST
Created attachment 45285 [details]
Patch v1
Comment 2 WebKit Review Bot 2009-12-20 10:04:16 PST
style-queue ran check-webkit-style on attachment 45285 [details] without any errors.
Comment 3 Adam Barth 2009-12-20 10:14:19 PST
Comment on attachment 45285 [details]
Patch v1

Comment 4 WebKit Commit Bot 2009-12-20 10:22:19 PST
Comment on attachment 45285 [details]
Patch v1

Clearing flags on attachment: 45285

Committed r52423: <http://trac.webkit.org/changeset/52423>
Comment 5 WebKit Commit Bot 2009-12-20 10:22:25 PST
All reviewed patches have been landed.  Closing bug.