Bug 32788 - [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
: [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-12-20 03:57 PST by
Modified: 2009-12-20 08:26 PST (History)


Attachments
Proposed patch (1.81 KB, patch)
2009-12-20 04:00 PST, Alejandro G. Castro
no flags Review Patch | Details | Formatted Diff | Diff
Proposed patch (4.65 KB, patch)
2009-12-20 07:06 PST, Alejandro G. Castro
no flags Review Patch | Details | Formatted Diff | Diff
Proposed patch (4.65 KB, patch)
2009-12-20 07:24 PST, Alejandro G. Castro
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-12-20 03:57:04 PST
The test is failing in the bots.
------- Comment #1 From 2009-12-20 04:00:13 PST -------
Created an attachment (id=45269) [details]
Proposed patch

Added fixed font size.
------- Comment #2 From 2009-12-20 04:05:08 PST -------
style-queue ran check-webkit-style on attachment 45269 [details] without any errors.
------- Comment #3 From 2009-12-20 04:09:09 PST -------
(From update of attachment 45269 [details])
Looks good (and works for me).
------- Comment #4 From 2009-12-20 04:18:41 PST -------
(From update of attachment 45269 [details])
Clearing flags on attachment: 45269

Committed r52413: <http://trac.webkit.org/changeset/52413>
------- Comment #5 From 2009-12-20 04:18:47 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #6 From 2009-12-20 06:56:05 PST -------
This fix does not fix the problem, we have to create a test that does not use fixed values for the events positions.
------- Comment #7 From 2009-12-20 07:06:40 PST -------
Created an attachment (id=45275) [details]
Proposed patch

Avoid using fixed mouse positions, it was causing problems in the bots, and add button to the click count function to avoid double paste with different buttons.
------- Comment #8 From 2009-12-20 07:10:10 PST -------
style-queue ran check-webkit-style on attachment 45275 [details] without any errors.
------- Comment #9 From 2009-12-20 07:24:39 PST -------
Created an attachment (id=45278) [details]
Proposed patch

Small nitpick.
------- Comment #10 From 2009-12-20 07:25:42 PST -------
style-queue ran check-webkit-style on attachment 45278 [details] without any errors.
------- Comment #11 From 2009-12-20 08:17:59 PST -------
(From update of attachment 45278 [details])
This should work better, thanks =). Tested locally, let's see if the bots like it.
------- Comment #12 From 2009-12-20 08:26:24 PST -------
(From update of attachment 45278 [details])
Clearing flags on attachment: 45278

Committed r52419: <http://trac.webkit.org/changeset/52419>
------- Comment #13 From 2009-12-20 08:26:30 PST -------
All reviewed patches have been landed.  Closing bug.