Bug 32780 - Use memcache to make dashboard to fast
Summary: Use memcache to make dashboard to fast
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-19 19:52 PST by Adam Barth
Modified: 2009-12-20 00:28 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.56 KB, patch)
2009-12-19 19:53 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-19 19:52:23 PST 
Fast is good!
Comment 1 Adam Barth 2009-12-19 19:53:21 PST 
Created attachment 45255 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-19 19:54:37 PST 
style-queue ran check-webkit-style on attachment 45255 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-19 22:56:59 PST 
Comment on attachment 45255 [details]
Patch

remove_api seems unrelated.

I don't see why you broke queue_name and bug_id out into local variables in UpdateStatus

Why change it to use a regexp if we compile every time?
74         regexp = re.compile("-")
 75         return regexp.sub("_", dashed_name)

replace is simpler, no?

Why do we have 3 copies of the string "attachment-summary"?  Seems error prone.

Looks OK though.
Comment 4 Adam Barth 2009-12-20 00:27:58 PST 
Comment on attachment 45255 [details]
Patch

Clearing flags on attachment: 45255

Committed r52404: <http://trac.webkit.org/changeset/52404>
Comment 5 Adam Barth 2009-12-20 00:28:07 PST 
All reviewed patches have been landed.  Closing bug.