Bug 32751 - upstream several platform-specific chromium plugin tests
Summary: upstream several platform-specific chromium plugin tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
Depends on:
Reported: 2009-12-18 16:04 PST by Dirk Pranke
Modified: 2009-12-21 15:50 PST (History)
5 users (show)

See Also:

Patch (17.34 KB, patch)
2009-12-18 16:05 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (17.30 KB, patch)
2009-12-21 14:59 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2009-12-18 16:04:29 PST
upstreaming a few platform-specific tests from chromium.org. Most of these rely on features that have been added to the chromium port of the test plugin that we will need to upstream when we upstream our revised DumpRenderTree/TestShell driver.
Comment 1 Dirk Pranke 2009-12-18 16:05:29 PST
Created attachment 45198 [details]
Comment 2 WebKit Review Bot 2009-12-18 16:06:45 PST
style-queue ran check-webkit-style on attachment 45198 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-19 12:08:30 PST
OK.  Should be easy enough to add to DumpRenderTree eventually as well.
Comment 4 WebKit Commit Bot 2009-12-20 02:35:44 PST
Comment on attachment 45198 [details]

Rejecting patch 45198 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
tform/chromium/plugins' is not a file

    The following files contain tab characters:


    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/git/libexec/git-core/git-svn line 558

Full output: http://webkit-commit-queue.appspot.com/results/136250
Comment 5 Dirk Pranke 2009-12-21 14:59:44 PST
Created attachment 45352 [details]
Comment 6 Dirk Pranke 2009-12-21 15:00:20 PST
submitted revised patch with tabs removed.
Comment 7 WebKit Review Bot 2009-12-21 15:01:15 PST
style-queue ran check-webkit-style on attachment 45352 [details] without any errors.
Comment 8 WebKit Commit Bot 2009-12-21 15:50:09 PST
Comment on attachment 45352 [details]

Clearing flags on attachment: 45352

Committed r52462: <http://trac.webkit.org/changeset/52462>
Comment 9 WebKit Commit Bot 2009-12-21 15:50:15 PST
All reviewed patches have been landed.  Closing bug.