WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32742
upstream fast/events/iframe-onload-remove-self-no-crash.html
https://bugs.webkit.org/show_bug.cgi?id=32742
Summary
upstream fast/events/iframe-onload-remove-self-no-crash.html
Dirk Pranke
Reported
2009-12-18 14:38:33 PST
Upstream a test from chromium.org where we had a race removing objects from a frame and an iframe.
Attachments
Patch
(2.93 KB, patch)
2009-12-18 14:39 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
Patch
(2.90 KB, patch)
2009-12-21 16:23 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
ignore this - patch submitted to the wrong bug.
(3.39 KB, patch)
2009-12-21 17:50 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2009-12-18 14:39:35 PST
Created
attachment 45188
[details]
Patch
WebKit Review Bot
Comment 2
2009-12-18 14:43:42 PST
style-queue ran check-webkit-style on
attachment 45188
[details]
without any errors.
Eric Seidel (no email)
Comment 3
2009-12-19 12:14:31 PST
Comment on
attachment 45188
[details]
Patch I could have sworn I wrote a very similar (if not the same) test for webkit.org? Do we know what the orginal chromium/webkit bug which produced this test was?
Darin Adler
Comment 4
2009-12-20 21:12:17 PST
Comment on
attachment 45188
[details]
Patch Not sure this really belongs in fast/events. I know that the load event is an event, but this seems more like a frame test to me.
Dirk Pranke
Comment 5
2009-12-21 16:20:29 PST
There is a fast/frames/onload-remove-iframe-crash.html test, but it is somewhat different. The original crash and test predates our move to SVN (Eric, I can send you a pointer to the bug log). I agree that fast/frames is probably a better place for this, so I'll submit a new patch.
Dirk Pranke
Comment 6
2009-12-21 16:23:25 PST
Created
attachment 45357
[details]
Patch
WebKit Review Bot
Comment 7
2009-12-21 16:28:15 PST
style-queue ran check-webkit-style on
attachment 45357
[details]
without any errors.
Dirk Pranke
Comment 8
2009-12-21 17:50:04 PST
Created
attachment 45360
[details]
ignore this - patch submitted to the wrong bug.
Eric Seidel (no email)
Comment 9
2009-12-21 22:42:23 PST
Comment on
attachment 45357
[details]
Patch OK. Setting cq+ too since you're not yet a committer. Soon! :)
WebKit Commit Bot
Comment 10
2009-12-21 23:04:51 PST
Comment on
attachment 45357
[details]
Patch Clearing flags on attachment: 45357 Committed
r52484
: <
http://trac.webkit.org/changeset/52484
>
WebKit Commit Bot
Comment 11
2009-12-21 23:04:56 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug