Bug 32742 - upstream fast/events/iframe-onload-remove-self-no-crash.html
Summary: upstream fast/events/iframe-onload-remove-self-no-crash.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-18 14:38 PST by Dirk Pranke
Modified: 2009-12-21 23:04 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.93 KB, patch)
2009-12-18 14:39 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (2.90 KB, patch)
2009-12-21 16:23 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
ignore this - patch submitted to the wrong bug. (3.39 KB, patch)
2009-12-21 17:50 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2009-12-18 14:38:33 PST
Upstream a test from chromium.org where we had a race removing objects from a frame and an iframe.
Comment 1 Dirk Pranke 2009-12-18 14:39:35 PST
Created attachment 45188 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-18 14:43:42 PST
style-queue ran check-webkit-style on attachment 45188 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-19 12:14:31 PST
Comment on attachment 45188 [details]
Patch

I could have sworn I wrote a very similar (if not the same) test for webkit.org?  Do we know what the orginal chromium/webkit bug which produced this test was?
Comment 4 Darin Adler 2009-12-20 21:12:17 PST
Comment on attachment 45188 [details]
Patch

Not sure this really belongs in fast/events. I know that the load event is an event, but this seems more like a frame test to me.
Comment 5 Dirk Pranke 2009-12-21 16:20:29 PST
There is a fast/frames/onload-remove-iframe-crash.html test, but it is somewhat different. The original crash and test predates our move to SVN (Eric, I can send you a pointer to the bug log).

I agree that fast/frames is probably a better place for this, so I'll submit a new patch.
Comment 6 Dirk Pranke 2009-12-21 16:23:25 PST
Created attachment 45357 [details]
Patch
Comment 7 WebKit Review Bot 2009-12-21 16:28:15 PST
style-queue ran check-webkit-style on attachment 45357 [details] without any errors.
Comment 8 Dirk Pranke 2009-12-21 17:50:04 PST
Created attachment 45360 [details]
ignore this - patch submitted to the wrong bug.
Comment 9 Eric Seidel (no email) 2009-12-21 22:42:23 PST
Comment on attachment 45357 [details]
Patch

OK.  Setting cq+ too since you're not yet a committer.  Soon! :)
Comment 10 WebKit Commit Bot 2009-12-21 23:04:51 PST
Comment on attachment 45357 [details]
Patch

Clearing flags on attachment: 45357

Committed r52484: <http://trac.webkit.org/changeset/52484>
Comment 11 WebKit Commit Bot 2009-12-21 23:04:56 PST
All reviewed patches have been landed.  Closing bug.