Bug 32732 - addition of setTouchMocking breaks builds with Qt < 4.6.0
Summary: addition of setTouchMocking breaks builds with Qt < 4.6.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-18 12:44 PST by Keith Kyzivat
Modified: 2009-12-18 13:59 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Kyzivat 2009-12-18 12:44:01 PST
When compiling svn 52312 for Qt under Linux with Qt 4.5.0, I received the following compilation error:

Creating hashtable for ../../../JavaScriptCore/runtime/StringPrototype.cpp
In file included from /home/kyzivat/builds/WebKit/WebKit/qt/QtLauncher/main.cpp:702:
./main.moc: In member function ‘virtual int MainWindow::qt_metacall(QMetaObject::Call, int, void**)’:
./main.moc:215: error: ‘setTouchMocking’ was not declared in this scope
make[1]: *** [main.o] Error 1
make: *** [sub-WebKit-qt-QtLauncher-make_default-ordered] Error 2

Looking at WebKit/qt/QtLauncher/main.cpp, I see that setTouchMocking is only included if Qt version is >= 4.6.0.
Thus, in my environment, it would not include setTouchMocking implementation.
When Qt builds main.moc, it seems not to honor the #ifdef directive, and erroneously creates binding for setTouchMocking.
Comment 1 Keith Kyzivat 2009-12-18 12:47:16 PST
Forgot to mention -- this change was introduced with changeset [52250]
Comment 2 Ariya Hidayat 2009-12-18 13:59:17 PST
Fixed in r52340
http://trac.webkit.org/changeset/52340