Bug 32712 - WebKit crashes on svg font-face-uri element with empty href
Summary: WebKit crashes on svg font-face-uri element with empty href
Status: RESOLVED DUPLICATE of bug 32357
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-18 07:39 PST by Chang Shu
Modified: 2009-12-18 08:28 PST (History)
2 users (show)

See Also:

Attachments
fix patch (1.46 KB, patch)
2009-12-18 07:55 PST, Chang Shu 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2009-12-18 07:39:13 PST 
Either DumpRenderTree or any browsers will crash running the following svg page.

<?xml version="1.0"?>
<?xml-stylesheet href="data:text/css,text%7Bfont-family%3AACID3svgfont%7D"?>
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="100" height="100">
        
    <font-face font-family="ACID3svgfont">
        <font-face-src>
            <font-face-uri xlink:href=""/>
        </font-face-src>
    </font-face>
    <text>X</text>
</svg>
Comment 1 Chang Shu 2009-12-18 07:55:21 PST 
Created attachment 45149 [details]
fix patch

I didn't add a layout test for this crash. I feel the layout tests are growing too big if we add test cases for this type of code change. But if the reviewers prefer the other way, I can add it real quick.
Comment 2 Darin Adler 2009-12-18 08:17:44 PST 
(In reply to comment #1)
> I didn't add a layout test for this crash. I feel the layout tests are growing
> too big if we add test cases for this type of code change.

I do not agree. We do want a test for this kind of crash.
Comment 3 Darin Adler 2009-12-18 08:17:56 PST 
Comment on attachment 45149 [details]
fix patch

Please add a test case.
Comment 4 mitz 2009-12-18 08:28:41 PST 
This was filed as bug 32357 and fixed about 10 hours ago.

*** This bug has been marked as a duplicate of bug 32357 ***