Bug 32696 - HTMLInputElement::valueAsNumber support
Summary: HTMLInputElement::valueAsNumber support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://www.whatwg.org/specs/web-apps/...
Keywords:
Depends on: 32697
Blocks: HTML5Forms 29070 30847 34200 34240
  Show dependency treegraph
 
Reported: 2009-12-17 22:03 PST by Kent Tamura
Modified: 2010-01-27 20:45 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch (55.41 KB, patch)
2010-01-26 01:24 PST, Kent Tamura
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2009-12-17 22:03:26 PST
It is helpful to implement min/max/step attribute for the date&time types.
Comment 1 Kent Tamura 2010-01-26 01:24:12 PST
Created attachment 47393 [details]
Proposed patch
Comment 2 Kent Tamura 2010-01-26 01:25:40 PST
Add Darin to cc, who reviewed all of patches for valueAsDate. valueAsDate is very related to valueAsNumber.
Comment 3 Darin Adler 2010-01-26 09:01:49 PST
Comment on attachment 47393 [details]
Proposed patch

> +    const double nan = std::numeric_limits<double>::quiet_NaN();

Normally we omit the "std" for things like this, and have "using namespace std" at the top of the file.

r=me
Comment 4 Kent Tamura 2010-01-26 20:46:40 PST
(In reply to comment #3)
> (From update of attachment 47393 [details])
> > +    const double nan = std::numeric_limits<double>::quiet_NaN();
> 
> Normally we omit the "std" for things like this, and have "using namespace std"
> at the top of the file.

Removed std::, and landed as r53893.
Comment 5 Brian Weinstein 2010-01-27 16:24:16 PST
This test failed on Windows since it was created. Landed expected failing results for Windows in r53959.
Comment 6 Kent Tamura 2010-01-27 16:39:24 PST
(In reply to comment #5)
> This test failed on Windows since it was created. Landed expected failing
> results for Windows in r53959.

I'll investigate it today.
Comment 7 Kent Tamura 2010-01-27 20:45:24 PST
(In reply to comment #6)
> (In reply to comment #5)
> > This test failed on Windows since it was created. Landed expected failing
> > results for Windows in r53959.
> 
> I'll investigate it today.

I made a bug entry for the failure: Bug#34240.