Bug 32693 - upstream fast/text/fake-italic.html
Summary: upstream fast/text/fake-italic.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-17 19:07 PST by Dirk Pranke
Modified: 2009-12-20 02:01 PST (History)
3 users (show)

See Also:

Attachments
patch w/ test and mac baselines (3.33 KB, patch)
2009-12-17 19:10 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
first rev (23.51 KB, patch)
2009-12-18 12:02 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
add changelog msg (1023 bytes, patch)
2009-12-18 12:02 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
remove duplicate Changelog entries (613 bytes, patch)
2009-12-18 12:02 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
add test for emulating italic when there are no italic versions of a glyph (24.32 KB, patch)
2009-12-18 12:15 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2009-12-17 19:07:51 PST 
Upstreaming fast/text/fake-italic.html from chromium.org - this tests synthesizing a slanted/italic effect on fonts that don't have a true italic glyph.
Comment 1 Dirk Pranke 2009-12-17 19:10:03 PST 
Created attachment 45120 [details]
patch w/ test and mac baselines
Comment 2 Dirk Pranke 2009-12-17 19:11:34 PST 
Comment on attachment 45120 [details]
patch w/ test and mac baselines

hmm .. not sure if 'git diff' handled the .png properly :(
Comment 3 mitz 2009-12-17 20:08:54 PST 
(In reply to comment #2)
> (From update of attachment 45120 [details])
> hmm .. not sure if 'git diff' handled the .png properly :(

No, the PNG data is missing from the patch so it can’t be landed.
Comment 4 Dirk Pranke 2009-12-18 12:02:24 PST 
Created attachment 45167 [details]
first rev
Comment 5 Dirk Pranke 2009-12-18 12:02:27 PST 
Created attachment 45168 [details]
add changelog msg
Comment 6 Dirk Pranke 2009-12-18 12:02:30 PST 
Created attachment 45169 [details]
remove duplicate Changelog entries
Comment 7 Dirk Pranke 2009-12-18 12:15:17 PST 
Created attachment 45171 [details]
add test for emulating italic when there are no italic versions of a glyph
Comment 8 WebKit Review Bot 2009-12-18 12:17:55 PST 
style-queue ran check-webkit-style on attachment 45171 [details] without any errors.
Comment 9 WebKit Commit Bot 2009-12-20 02:01:17 PST 
Comment on attachment 45171 [details]
add test for emulating italic when there are no italic versions of a glyph

Clearing flags on attachment: 45171

Committed r52407: <http://trac.webkit.org/changeset/52407>
Comment 10 WebKit Commit Bot 2009-12-20 02:01:28 PST 
All reviewed patches have been landed.  Closing bug.