Bug 32666 – AX: DRT needs to support URL for accessibility

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

DRT needs to support the ability to fetch a URL

[chris fleizach]

Created attachment 45078 [details]
patch

Simple patch. No use case in open source code yet, but we want it to be down-merged to other platforms

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45078 [details] without any errors.

[David Kilzer (:ddkilzer)]

Comment on attachment 45078 [details]
patch

> Index: WebKitTools/ChangeLog
> Index: WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp
> +JSStringRef AccessibilityUIElement::url()
> +{
> +    return 0;
> +}

Please add a FIXME.  Also, other "FIXME" methods that return JSStringRef use JSStringCreateWithCharacters(0, 0) instead:

    // FIXME: implement
    return JSStringCreateWithCharacters(0, 0);

> Index: WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
> +JSStringRef AccessibilityUIElement::url()
> +{
> +    return 0;
> +}

Again, I think this should use JSStringCreateWithCharacters(0, 0):

    return JSStringCreateWithCharacters(0, 0);

r=me with these changes

[chris fleizach]

http://trac.webkit.org/changeset/52272