Bug 32666 - AX: DRT needs to support URL for accessibility
Summary: AX: DRT needs to support URL for accessibility
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-17 09:30 PST by chris fleizach
Modified: 2009-12-17 11:48 PST (History)
1 user (show)

See Also:

Attachments
patch (4.60 KB, patch)
2009-12-17 09:35 PST, chris fleizach 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-12-17 09:30:44 PST 
DRT needs to support the ability to fetch a URL
Comment 1 chris fleizach 2009-12-17 09:35:29 PST 
Created attachment 45078 [details]
patch

Simple patch. No use case in open source code yet, but we want it to be down-merged to other platforms
Comment 2 WebKit Review Bot 2009-12-17 09:37:44 PST 
style-queue ran check-webkit-style on attachment 45078 [details] without any errors.
Comment 3 David Kilzer (:ddkilzer) 2009-12-17 11:42:37 PST 
Comment on attachment 45078 [details]
patch

> Index: WebKitTools/ChangeLog
> Index: WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp
> +JSStringRef AccessibilityUIElement::url()
> +{
> +    return 0;
> +}

Please add a FIXME.  Also, other "FIXME" methods that return JSStringRef use JSStringCreateWithCharacters(0, 0) instead:

    // FIXME: implement
    return JSStringCreateWithCharacters(0, 0);

> Index: WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
> +JSStringRef AccessibilityUIElement::url()
> +{
> +    return 0;
> +}

Again, I think this should use JSStringCreateWithCharacters(0, 0):

    return JSStringCreateWithCharacters(0, 0);

r=me with these changes
Comment 4 chris fleizach 2009-12-17 11:48:56 PST 
http://trac.webkit.org/changeset/52272