Bug 32660 - Allow custom memory allocation control for inspector's classes
Summary: Allow custom memory allocation control for inspector's classes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-12-17 07:06 PST by Zoltan Horvath
Modified: 2009-12-17 16:51 PST (History)
2 users (show)

See Also:

proposed patch (2.78 KB, patch)
2009-12-17 07:07 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-12-17 07:06:02 PST
Inherits the following classes from Noncopyable because these are instantiated by 'new' and no need to be copyable:                                           
class name                  - instantiated at:  WebCore/'location'                          

class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72                        
class ConsoleMessage - inspector/InspectorController.cpp:329                         
class InspectorController   - page/Page.cpp:119
Comment 1 Zoltan Horvath 2009-12-17 07:07:03 PST
Created attachment 45063 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-17 07:11:52 PST
style-queue ran check-webkit-style on attachment 45063 [details] without any errors.
Comment 3 Darin Adler 2009-12-17 16:39:17 PST
Comment on attachment 45063 [details]
proposed patch

> -    class JavaScriptDebugServer : JSC::Debugger {
> +    class JavaScriptDebugServer : JSC::Debugger, public Noncopyable {

I think it would be better to change DEFINE_STATIC_LOCAL to use fastNew rather than changing all the classes using it to inherit from Noncopyable and FastAllocBase. I'm not sure why I didn't think of this earlier.

r=me on this, but it seems it would be worthwhile to do that
Comment 4 WebKit Commit Bot 2009-12-17 16:51:20 PST
Comment on attachment 45063 [details]
proposed patch

Clearing flags on attachment: 45063

Committed r52294: <http://trac.webkit.org/changeset/52294>
Comment 5 WebKit Commit Bot 2009-12-17 16:51:26 PST
All reviewed patches have been landed.  Closing bug.