RESOLVED FIXED 32660
Allow custom memory allocation control for inspector's classes 
https://bugs.webkit.org/show_bug.cgi?id=32660
Summary Allow custom memory allocation control for inspector's classes
Zoltan Horvath
Reported 2009-12-17 07:06:02 PST
Inherits the following classes from Noncopyable because these are instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72 class ConsoleMessage - inspector/InspectorController.cpp:329 class InspectorController - page/Page.cpp:119
Attachments
proposed patch (2.78 KB, patch)
2009-12-17 07:07 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2009-12-17 07:07:03 PST
Created attachment 45063 [details] proposed patch
WebKit Review Bot
Comment 2 2009-12-17 07:11:52 PST
style-queue ran check-webkit-style on attachment 45063 [details] without any errors.
Darin Adler
Comment 3 2009-12-17 16:39:17 PST
Comment on attachment 45063 [details] proposed patch > - class JavaScriptDebugServer : JSC::Debugger { > + class JavaScriptDebugServer : JSC::Debugger, public Noncopyable { I think it would be better to change DEFINE_STATIC_LOCAL to use fastNew rather than changing all the classes using it to inherit from Noncopyable and FastAllocBase. I'm not sure why I didn't think of this earlier. r=me on this, but it seems it would be worthwhile to do that
WebKit Commit Bot
Comment 4 2009-12-17 16:51:20 PST
Comment on attachment 45063 [details] proposed patch Clearing flags on attachment: 45063 Committed r52294: <http://trac.webkit.org/changeset/52294>
WebKit Commit Bot
Comment 5 2009-12-17 16:51:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.