Bug 32659 – gtk: quirks mode setting

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Evan Martin]

Created attachment 45062 [details]
Patch

Expose the site-specific quirks setting for WebKitGtk.

[Evan Martin]

BTW, I don't know how to test this.

[WebKit Review Bot]

Attachment 45062 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebsettings.cpp:102:  enable_site_specific_quirks is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1

[Xan Lopez]

Comment on attachment 45062 [details]
Patch

You forgot to update the setting when webkit_web_view_settings_notify is called. Looks good otherwise, thanks!

[Evan Martin]

Created attachment 45066 [details]
gtk: expose the page quirks setting

[WebKit Review Bot]

Attachment 45066 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebsettings.cpp:102:  enable_site_specific_quirks is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1

[Gustavo Noronha (kov)]

Comment on attachment 45066 [details]
gtk: expose the page quirks setting

> +    /**
> +     * WebKitWebSettings::enable-site-specific-quirks
> +     *
> +     * Whether to turn on site-specific hacks.  Turning this on will
> +     * tell WebKitGTK+ to use some site-specific workarounds for
> +     * better web compatibility.  For example, older versions of
> +     * MediaWiki will incorrectly send WebKit a css file with KHTML
> +     * workarounds.  By turning on site-specific quirks, WebKit will
> +     * special-case this and other cases to make the sites work.
> +     *
> +     * Since: 1.1.8

That should be 1.1.18 =) Otherwise looks fine to me. I'll leave the r+ for Xan.

[Evan Martin]

Created attachment 45068 [details]
gtk: expose the page quirks setting

[WebKit Review Bot]

Attachment 45068 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebsettings.cpp:102:  enable_site_specific_quirks is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1

[Xan Lopez]

Comment on attachment 45068 [details]
gtk: expose the page quirks setting

I am Krusty the Klown and I endorse this product or service.

[WebKit Commit Bot]

Comment on attachment 45068 [details]
gtk: expose the page quirks setting

Clearing flags on attachment: 45068

Committed r52254: <http://trac.webkit.org/changeset/52254>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.