Bug 32659 - gtk: quirks mode setting
Summary: gtk: quirks mode setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-17 06:58 PST by Evan Martin
Modified: 2009-12-17 07:57 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.21 KB, patch)
2009-12-17 06:58 PST, Evan Martin
no flags Details | Formatted Diff | Diff
gtk: expose the page quirks setting (6.76 KB, patch)
2009-12-17 07:35 PST, Evan Martin
no flags Details | Formatted Diff | Diff
gtk: expose the page quirks setting (6.76 KB, patch)
2009-12-17 07:42 PST, Evan Martin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2009-12-17 06:58:11 PST
Created attachment 45062 [details]
Patch

Expose the site-specific quirks setting for WebKitGtk.
Comment 1 Evan Martin 2009-12-17 07:00:41 PST
BTW, I don't know how to test this.
Comment 2 WebKit Review Bot 2009-12-17 07:01:31 PST
Attachment 45062 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebsettings.cpp:102:  enable_site_specific_quirks is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1
Comment 3 Xan Lopez 2009-12-17 07:08:37 PST
Comment on attachment 45062 [details]
Patch

You forgot to update the setting when webkit_web_view_settings_notify is called. Looks good otherwise, thanks!
Comment 4 Evan Martin 2009-12-17 07:35:07 PST
Created attachment 45066 [details]
gtk: expose the page quirks setting
Comment 5 WebKit Review Bot 2009-12-17 07:37:55 PST
Attachment 45066 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebsettings.cpp:102:  enable_site_specific_quirks is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1
Comment 6 Gustavo Noronha (kov) 2009-12-17 07:39:03 PST
Comment on attachment 45066 [details]
gtk: expose the page quirks setting

> +    /**
> +     * WebKitWebSettings::enable-site-specific-quirks
> +     *
> +     * Whether to turn on site-specific hacks.  Turning this on will
> +     * tell WebKitGTK+ to use some site-specific workarounds for
> +     * better web compatibility.  For example, older versions of
> +     * MediaWiki will incorrectly send WebKit a css file with KHTML
> +     * workarounds.  By turning on site-specific quirks, WebKit will
> +     * special-case this and other cases to make the sites work.
> +     *
> +     * Since: 1.1.8

That should be 1.1.18 =) Otherwise looks fine to me. I'll leave the r+ for Xan.
Comment 7 Evan Martin 2009-12-17 07:42:25 PST
Created attachment 45068 [details]
gtk: expose the page quirks setting
Comment 8 WebKit Review Bot 2009-12-17 07:43:35 PST
Attachment 45068 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebsettings.cpp:102:  enable_site_specific_quirks is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1
Comment 9 Xan Lopez 2009-12-17 07:46:25 PST
Comment on attachment 45068 [details]
gtk: expose the page quirks setting

I am Krusty the Klown and I endorse this product or service.
Comment 10 WebKit Commit Bot 2009-12-17 07:56:55 PST
Comment on attachment 45068 [details]
gtk: expose the page quirks setting

Clearing flags on attachment: 45068

Committed r52254: <http://trac.webkit.org/changeset/52254>
Comment 11 WebKit Commit Bot 2009-12-17 07:57:04 PST
All reviewed patches have been landed.  Closing bug.