Bug 32629 - EWS should support Gtk build
Summary: EWS should support Gtk build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-16 12:52 PST by Evan Martin
Modified: 2009-12-16 23:41 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2009-12-16 12:52 PST, Evan Martin 		no flags Details | Formatted Diff | Diff
patch that passes unit test (3.89 KB, patch)
2009-12-16 13:45 PST, Evan Martin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2009-12-16 12:52:19 PST 
Created attachment 45009 [details]
Patch

The EWS should support WebKit GTK.
Comment 1 Adam Barth 2009-12-16 13:03:11 PST 
This looks great.  Can you add a ChangeLog and a unit test for the GtkPort (there are examples in webkitport_unittest)?  We don't have a good way of testing the GtkEWS class yet.
Comment 2 Evan Martin 2009-12-16 13:45:45 PST 
Created attachment 45011 [details]
patch that passes unit test
Comment 3 WebKit Review Bot 2009-12-16 13:49:56 PST 
style-queue ran check-webkit-style on attachment 45011 [details] without any errors.
Comment 4 Adam Barth 2009-12-16 14:04:30 PST 
Comment on attachment 45011 [details]
patch that passes unit test

Awesome.  Thanks!
Comment 5 Adam Barth 2009-12-16 23:41:20 PST 
Comment on attachment 45011 [details]
patch that passes unit test

Clearing flags on attachment: 45011

Committed r52240: <http://trac.webkit.org/changeset/52240>
Comment 6 Adam Barth 2009-12-16 23:41:26 PST 
All reviewed patches have been landed.  Closing bug.