RESOLVED FIXED 32629
EWS should support Gtk build 
https://bugs.webkit.org/show_bug.cgi?id=32629
Summary EWS should support Gtk build
Evan Martin
Reported 2009-12-16 12:52:19 PST
Created attachment 45009 [details] Patch The EWS should support WebKit GTK.
Attachments
Patch (1.84 KB, patch)
2009-12-16 12:52 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
patch that passes unit test (3.89 KB, patch)
2009-12-16 13:45 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-16 13:03:11 PST
This looks great. Can you add a ChangeLog and a unit test for the GtkPort (there are examples in webkitport_unittest)? We don't have a good way of testing the GtkEWS class yet.
Evan Martin
Comment 2 2009-12-16 13:45:45 PST
Created attachment 45011 [details] patch that passes unit test
WebKit Review Bot
Comment 3 2009-12-16 13:49:56 PST
style-queue ran check-webkit-style on attachment 45011 [details] without any errors.
Adam Barth
Comment 4 2009-12-16 14:04:30 PST
Comment on attachment 45011 [details] patch that passes unit test Awesome. Thanks!
Adam Barth
Comment 5 2009-12-16 23:41:20 PST
Comment on attachment 45011 [details] patch that passes unit test Clearing flags on attachment: 45011 Committed r52240: <http://trac.webkit.org/changeset/52240>
Adam Barth
Comment 6 2009-12-16 23:41:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.