Bug 32612 - [GTK] Add WebKitEnableCaretBrowsing key to the layoutTestController.overridePreference call
Summary: [GTK] Add WebKitEnableCaretBrowsing key to the layoutTestController.overrideP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-16 08:47 PST by Alejandro G. Castro
Modified: 2009-12-17 13:26 PST (History)
4 users (show)

See Also:

Attachments
Proposed patch adding the API (1.30 KB, patch)
2009-12-16 08:52 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Proposed patch (5.82 KB, patch)
2009-12-16 08:54 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Proposed patch (2.14 KB, patch)
2009-12-17 03:02 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2009-12-16 08:47:34 PST 
We need this API in order to test the caret browsing from the DRT.
Comment 1 Alejandro G. Castro 2009-12-16 08:52:49 PST 
Created attachment 44981 [details]
Proposed patch adding the API
Comment 2 Alejandro G. Castro 2009-12-16 08:54:37 PST 
Created attachment 44982 [details]
Proposed patch

Upload the right patch.
Comment 3 WebKit Review Bot 2009-12-16 08:55:08 PST 
Attachment 44982 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:565:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1
Comment 4 Eric Seidel (no email) 2009-12-16 13:15:47 PST 
I wonder if we shouldn't just enable/disable this via the layoutTestController.overridePreference call instead.  We'd just have to come up with a name for this preference.
Comment 5 Alejandro G. Castro 2009-12-17 01:30:54 PST 
(In reply to comment #4)
> I wonder if we shouldn't just enable/disable this via the
> layoutTestController.overridePreference call instead.  We'd just have to come
> up with a name for this preference.

You are right, thanks for the comment.
Comment 6 Alejandro G. Castro 2009-12-17 01:39:05 PST 
Resolved by mistake, we need the patch adding the property.
Comment 7 Alejandro G. Castro 2009-12-17 03:02:33 PST 
Created attachment 45051 [details]
Proposed patch

Using the overridePreference API.
Comment 8 WebKit Review Bot 2009-12-17 03:06:13 PST 
style-queue ran check-webkit-style on attachment 45051 [details] without any errors.
Comment 9 Eric Seidel (no email) 2009-12-17 12:59:39 PST 
Comment on attachment 45051 [details]
Proposed patch

LGTM!
Comment 10 WebKit Commit Bot 2009-12-17 13:26:11 PST 
Comment on attachment 45051 [details]
Proposed patch

Clearing flags on attachment: 45051

Committed r52284: <http://trac.webkit.org/changeset/52284>
Comment 11 WebKit Commit Bot 2009-12-17 13:26:16 PST 
All reviewed patches have been landed.  Closing bug.