WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 32609
Web Inspector: Make Elements tree, properties section and resources view monospace.
https://bugs.webkit.org/show_bug.cgi?id=32609
Summary
Web Inspector: Make Elements tree, properties section and resources view mono...
Pavel Feldman
Reported
2009-12-16 06:38:08 PST
Created
attachment 44970
[details]
[IMAGE] Screen 1 See screenshots attached.
Attachments
[IMAGE] Screen 1
(154.95 KB, image/png)
2009-12-16 06:38 PST
,
Pavel Feldman
no flags
Details
[IMAGE] Screen 2
(155.78 KB, image/png)
2009-12-16 06:38 PST
,
Pavel Feldman
no flags
Details
[PATCH] Proposed change.
(5.05 KB, patch)
2009-12-16 06:42 PST
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
[PATCH] Same with fix for windows platform and console prompt.
(6.63 KB, patch)
2009-12-16 07:08 PST
,
Pavel Feldman
timothy
: review+
Details
Formatted Diff
Diff
[IMAGE] Win / Chromium looks
(82.14 KB, image/png)
2009-12-16 07:28 PST
,
Pavel Feldman
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2009-12-16 06:38:38 PST
Created
attachment 44971
[details]
[IMAGE] Screen 2
Pavel Feldman
Comment 2
2009-12-16 06:42:21 PST
Created
attachment 44972
[details]
[PATCH] Proposed change.
WebKit Review Bot
Comment 3
2009-12-16 06:47:28 PST
style-queue ran check-webkit-style on
attachment 44972
[details]
without any errors.
Pavel Feldman
Comment 4
2009-12-16 07:08:40 PST
Created
attachment 44974
[details]
[PATCH] Same with fix for windows platform and console prompt.
WebKit Review Bot
Comment 5
2009-12-16 07:13:12 PST
style-queue ran check-webkit-style on
attachment 44974
[details]
without any errors.
Pavel Feldman
Comment 6
2009-12-16 07:28:34 PST
Created
attachment 44976
[details]
[IMAGE] Win / Chromium looks
Timothy Hatcher
Comment 7
2009-12-16 09:45:42 PST
Comment on
attachment 44974
[details]
[PATCH] Same with fix for windows platform and console prompt.
> + span.addStyleClass("console-formatted-trace source code");
Should be source-code.
> + white-space: pre;
This should be pre-wrap, pre is pretty dangerous.
> + font-family: Monaco, monospace;
Some people are going to ask for Menlo on Snow Leopard… But alti-alias monospace is pretty bad in my book. So I think Monaco is good. Fix the class name before landing.
Pavel Feldman
Comment 8
2009-12-16 10:26:18 PST
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/PropertiesSection.js M WebCore/inspector/front-end/ResourceView.js M WebCore/inspector/front-end/inspector.css Committed
r52203
Pavel Feldman
Comment 9
2009-12-16 10:27:44 PST
(landed with all comments addressed)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug