Bug 32607 - [Qt] Code cleanup: Make better separation between QJavaScript's "public" and "private" classes
Summary: [Qt] Code cleanup: Make better separation between QJavaScript's "public" and ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jędrzej Nowacki
Keywords: Qt
Depends on: 32565
Blocks: 32608 32657
  Show dependency treegraph
Reported: 2009-12-16 05:45 PST by Jędrzej Nowacki
Modified: 2010-01-04 06:29 PST (History)
2 users (show)

See Also:

patch v1 (4.49 KB, patch)
2009-12-16 05:51 PST, Jędrzej Nowacki
jedrzej.nowacki: review-
jedrzej.nowacki: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2009-12-16 05:45:57 PST
The QJavaScript API implementation is small enough to keep clear separation between a "public" and a "private" classes. For implementation simplicity we should assume that a "public" class should only propagate functions calls and convert a data (from "private" to "public" and from "public" to "private").

The bug apply only if the bug 32565 will be accepted to commit.
Comment 1 Jędrzej Nowacki 2009-12-16 05:51:53 PST
Created attachment 44966 [details]
patch v1

The patch should be landed after bug 32565.
Comment 2 Jędrzej Nowacki 2010-01-04 06:29:25 PST
The base patch (bug 32565) wasn't accepted, so the bug is not valid.