Bug 32602 – Correctly report keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad arrow key events on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kinuko Yasuda]

There're no layout tests for Numpad arrow key events as current implementation of our eventSender does not support sending numpad key events.
Related issue for chromium/gtk: https://bugs.webkit.org/show_bug.cgi?id=28247

[Kinuko Yasuda]

Created attachment 45486 [details]
Support key location argument in keyboard event methods for EventSender.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45486 [details] without any errors.

[Darin Adler]

It's strange to call this "add a layout test" since it also changes the behavior of the platform layer. Is that new platform-layer code for the benefit of the layout test only, or does it affect actual browser behavior too?

[Maciej Stachowiak]

Comment on attachment 45486 [details]
Support key location argument in keyboard event methods for EventSender.

Please update the WebCore and WebKit ChangeLog to explain the the apparent behavior change. If the test will only pass on some platforms, please add it to the skipped list on other platforms. Please also retitle the bug and its mention in the ChangeLog to cite the behavior change, not just the added tests.

For example, "Correctly report keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad arrow key events" would be a better explanation.

r- to address these issues.

[Kinuko Yasuda]

(In reply to comment #3)
> It's strange to call this "add a layout test" since it also changes the
> behavior of the platform layer. Is that new platform-layer code for the benefit
> of the layout test only, or does it affect actual browser behavior too?

That's right, sorry for confusing things.  I was trying to do a few different things in the patch - I've filed another bug (https://bugs.webkit.org/show_bug.cgi?id=32983) and updated the bug summary to reflect the things better.

(In reply to comment #4)
> For example, "Correctly report keyLocation as DOM_KEY_LOCATION_NUMPAD for
> numeric pad arrow key events" would be a better explanation.

I'm going to separate the patch and update the explanations in the ChangeLog.
Thanks for reviewing,

[Kinuko Yasuda]

*** Bug 32983 has been marked as a duplicate of this bug. ***

[Kinuko Yasuda]

Updating the bug summary and have merged 32983 back to this one (sorry for the confusion).   I'm updating the patch as well shortly.

[Kinuko Yasuda]

Created attachment 45550 [details]
Support key location argument in keyboard event methods for EventSender.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45550 [details] without any errors.

[Maciej Stachowiak]

Comment on attachment 45550 [details]
Support key location argument in keyboard event methods for EventSender.

r=me

[WebKit Commit Bot]

Comment on attachment 45550 [details]
Support key location argument in keyboard event methods for EventSender.

Clearing flags on attachment: 45550

Committed r52608: <http://trac.webkit.org/changeset/52608>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.