Bug 32602 - Correctly report keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad arrow key events on Mac
Summary: Correctly report keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad arrow...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 32983 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-16 02:11 PST by Kinuko Yasuda
Modified: 2009-12-28 22:33 PST (History)
5 users (show)

See Also:


Attachments
Support key location argument in keyboard event methods for EventSender. (13.36 KB, patch)
2009-12-25 06:04 PST, Kinuko Yasuda
no flags Details | Formatted Diff | Diff
Support key location argument in keyboard event methods for EventSender. (13.46 KB, patch)
2009-12-28 03:32 PST, Kinuko Yasuda
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2009-12-16 02:11:32 PST
There're no layout tests for Numpad arrow key events as current implementation of our eventSender does not support sending numpad key events.
Related issue for chromium/gtk: https://bugs.webkit.org/show_bug.cgi?id=28247
Comment 1 Kinuko Yasuda 2009-12-25 06:04:19 PST
Created attachment 45486 [details]
Support key location argument in keyboard event methods for EventSender.
Comment 2 WebKit Review Bot 2009-12-25 06:05:10 PST
style-queue ran check-webkit-style on attachment 45486 [details] without any errors.
Comment 3 Darin Adler 2009-12-25 20:14:04 PST
It's strange to call this "add a layout test" since it also changes the behavior of the platform layer. Is that new platform-layer code for the benefit of the layout test only, or does it affect actual browser behavior too?
Comment 4 Maciej Stachowiak 2009-12-28 01:52:35 PST
Comment on attachment 45486 [details]
Support key location argument in keyboard event methods for EventSender.

Please update the WebCore and WebKit ChangeLog to explain the the apparent behavior change. If the test will only pass on some platforms, please add it to the skipped list on other platforms. Please also retitle the bug and its mention in the ChangeLog to cite the behavior change, not just the added tests.

For example, "Correctly report keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad arrow key events" would be a better explanation.

r- to address these issues.
Comment 5 Kinuko Yasuda 2009-12-28 02:21:23 PST
(In reply to comment #3)
> It's strange to call this "add a layout test" since it also changes the
> behavior of the platform layer. Is that new platform-layer code for the benefit
> of the layout test only, or does it affect actual browser behavior too?

That's right, sorry for confusing things.  I was trying to do a few different things in the patch - I've filed another bug (https://bugs.webkit.org/show_bug.cgi?id=32983) and updated the bug summary to reflect the things better.

(In reply to comment #4)
> For example, "Correctly report keyLocation as DOM_KEY_LOCATION_NUMPAD for
> numeric pad arrow key events" would be a better explanation.

I'm going to separate the patch and update the explanations in the ChangeLog.
Thanks for reviewing,
Comment 6 Kinuko Yasuda 2009-12-28 03:05:35 PST
*** Bug 32983 has been marked as a duplicate of this bug. ***
Comment 7 Kinuko Yasuda 2009-12-28 03:12:47 PST
Updating the bug summary and have merged 32983 back to this one (sorry for the confusion).   I'm updating the patch as well shortly.
Comment 8 Kinuko Yasuda 2009-12-28 03:32:30 PST
Created attachment 45550 [details]
Support key location argument in keyboard event methods for EventSender.
Comment 9 WebKit Review Bot 2009-12-28 03:35:59 PST
style-queue ran check-webkit-style on attachment 45550 [details] without any errors.
Comment 10 Maciej Stachowiak 2009-12-28 18:28:13 PST
Comment on attachment 45550 [details]
Support key location argument in keyboard event methods for EventSender.

r=me
Comment 11 WebKit Commit Bot 2009-12-28 22:33:30 PST
Comment on attachment 45550 [details]
Support key location argument in keyboard event methods for EventSender.

Clearing flags on attachment: 45550

Committed r52608: <http://trac.webkit.org/changeset/52608>
Comment 12 WebKit Commit Bot 2009-12-28 22:33:36 PST
All reviewed patches have been landed.  Closing bug.