Bug 32600 - [Qt] fast/css/font-face-unused-source-loaded.html crashes
Summary: [Qt] fast/css/font-face-unused-source-loaded.html crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-12-16 00:44 PST by Csaba Osztrogonác
Modified: 2009-12-16 02:07 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2009-12-16 01:50 PST, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (2.80 KB, patch)
2009-12-16 01:56 PST, Simon Hausmann
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2009-12-16 00:44:33 PST
fast/css/font-face-unused-source-loaded.html introduced by 
http://trac.webkit.org/changeset/52174 crashed with QtWebKit on Linux.
( original bug: https://bugs.webkit.org/show_bug.cgi?id=32257 )

crash caused by the test before: fast/css/font-face-multiple-families.html

stderr on buildbot:
http://build.webkit.org/results/Qt%20Linux%20Release/r52188%20%284974%29/fast/css/font-face-unused-source-loaded-stderr.txt

In debug mode DumpRenderTree said there is an stderr file, but it isn't exist unfortunately.
Comment 1 Csaba Osztrogonác 2009-12-16 01:03:54 PST
fast/css/font-face-multiple-families.html added to skiplist until fix. 
http://trac.webkit.org/changeset/52190 (to keep buildbot green)
Comment 2 Simon Hausmann 2009-12-16 01:25:46 PST
Seems this line

font.setFamily(QFontDatabase::applicationFontFamilies(m_handle)[0]);

in FontCustomPlatformData::fontPlatformData causes it (out of bounds array access).
Comment 3 Simon Hausmann 2009-12-16 01:50:54 PST
Created attachment 44958 [details]
Patch
Comment 4 WebKit Review Bot 2009-12-16 01:52:05 PST
style-queue ran check-webkit-style on attachment 44958 [details] without any errors.
Comment 5 Simon Hausmann 2009-12-16 01:56:07 PST
Created attachment 44959 [details]
Patch
Comment 6 WebKit Review Bot 2009-12-16 01:57:25 PST
style-queue ran check-webkit-style on attachment 44959 [details] without any errors.
Comment 7 Holger Freyther 2009-12-16 01:59:59 PST
Comment on attachment 44959 [details]
Patch

I'm so incredible happy that "we" address regressions in a timely manner!
Comment 8 Simon Hausmann 2009-12-16 02:07:21 PST
Committed r52194: <http://trac.webkit.org/changeset/52194>