Bug 32598 – Flakiness in WebSocket handshake console message

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Fumitoshi Ukai]

In chromium port, handshake-error.html may outputs 3 lines of CONSOLE MESSAGE: line 0: Unexpected response code:101

[Fumitoshi Ukai]

Created attachment 44952 [details]
Fix flakiness in WebSocket handshake console message.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 44952 [details] without any errors.

[Alexey Proskuryakov]

Comment on attachment 44952 [details]
Fix flakiness in WebSocket handshake console message.

r=me

Is it be possible to make a reliable test for this? That would involve sending a large response that no reasonable implementation would coalesce into one didReceiveData call.

[Fumitoshi Ukai]

Committed r52234: <http://trac.webkit.org/changeset/52234>

[Fumitoshi Ukai]

(In reply to comment #3)
> (From update of attachment 44952 [details])
> r=me
> 
> Is it be possible to make a reliable test for this? That would involve sending
> a large response that no reasonable implementation would coalesce into one
> didReceiveData call.

I think it would be difficult to make a reliable test.
It must send several chunks for handshake response header and each chunk should be delivered as following order
   - first chunk. containing first line with bad response code, but not finished whole handshake message
   - bad response code, so it closes the SocketStreamHandle.
   - before didClose comes, it receives second chunk, which would be already queued while it is processing the first chunk.