Bug 32594 - [bzt] Add error handling to the early warning system
Summary: [bzt] Add error handling to the early warning system
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-15 20:28 PST by Adam Barth
Modified: 2009-12-16 13:17 PST (History)
3 users (show)

See Also:


Attachments
Work in progress (6.74 KB, patch)
2009-12-15 20:29 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Work in progress (6.44 KB, patch)
2009-12-15 22:38 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (5.10 KB, patch)
2009-12-15 23:58 PST, Adam Barth
no flags Details | Formatted Diff | Diff
patch (better error message) (5.63 KB, patch)
2009-12-16 09:33 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Bogus patch so you can see what the error message is like. (413 bytes, patch)
2009-12-16 09:52 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-15 20:28:17 PST
Now that we've got the ability to post blobs on the server, we should use these links in the EWS.
Comment 1 Adam Barth 2009-12-15 20:29:41 PST
Created attachment 44937 [details]
Work in progress
Comment 2 Adam Barth 2009-12-15 22:38:51 PST
Created attachment 44943 [details]
Work in progress
Comment 3 Adam Barth 2009-12-15 23:58:03 PST
Created attachment 44949 [details]
Patch
Comment 4 WebKit Review Bot 2009-12-15 23:58:52 PST
style-queue ran check-webkit-style on attachment 44949 [details] without any errors.
Comment 5 Adam Barth 2009-12-16 09:33:40 PST
Created attachment 44984 [details]
patch (better error message)
Comment 6 WebKit Review Bot 2009-12-16 09:36:04 PST
style-queue ran check-webkit-style on attachment 44984 [details] without any errors.
Comment 7 Adam Barth 2009-12-16 09:52:14 PST
Created attachment 44987 [details]
Bogus patch so you can see what the error message is like.
Comment 8 Adam Barth 2009-12-16 09:52:49 PST
Comment on attachment 44984 [details]
patch (better error message)

Oops.  I didn't mean to obsolete this patch.
Comment 9 WebKit Review Bot 2009-12-16 09:57:27 PST
style-queue ran check-webkit-style on attachment 44987 [details] without any errors.
Comment 10 WebKit Review Bot 2009-12-16 10:10:26 PST
Attachment 44987 [details] did not build on chromium:
Full output: http://webkit-commit-queue.appspot.com/results/127615
Comment 11 Eric Seidel (no email) 2009-12-16 12:05:46 PST
Comment on attachment 44984 [details]
patch (better error message)

Lgtm!
Comment 12 WebKit Commit Bot 2009-12-16 13:17:08 PST
Comment on attachment 44984 [details]
patch (better error message)

Clearing flags on attachment: 44984

Committed r52216: <http://trac.webkit.org/changeset/52216>
Comment 13 WebKit Commit Bot 2009-12-16 13:17:15 PST
All reviewed patches have been landed.  Closing bug.