RESOLVED FIXED32564
Removed the number heap 
https://bugs.webkit.org/show_bug.cgi?id=32564
Summary Removed the number heap
Geoffrey Garen
Reported 2009-12-15 09:15:03 PST
Created attachment 44884 [details] patch Patch coming.
Attachments
patch (36.78 KB, patch)
2009-12-15 09:15 PST, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2009-12-15 09:17:54 PST
Attachment 44884 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/runtime/Collector.h:199: CELLS_PER_BLOCK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1
Geoffrey Garen
Comment 2 2009-12-15 12:39:00 PST
Please ignore the style bot; it doesn't understand pre-existing code.
Oliver Hunt
Comment 3 2009-12-15 13:31:05 PST
Comment on attachment 44884 [details] patch r=me, alas poor collector templates i shall miss you all
Geoffrey Garen
Comment 4 2009-12-15 14:40:11 PST
Committed revision 52176.
Adam Barth
Comment 5 2009-12-15 19:06:02 PST
> Please ignore the style bot; it doesn't understand pre-existing code. Just to be clear, you think that the name CELLS_PER_BLOCK isn't correct style, but you're deciding not to change it in this patch. If you think CELLS_PER_BLOCK is in proper style, we can teach to the style bot not to complain.
Geoffrey Garen
Comment 6 2009-12-16 12:51:45 PST
> you think that the name CELLS_PER_BLOCK isn't correct style, > but you're deciding not to change it in this patch. Right.
Note You need to log in before you can comment on or make changes to this bug.