Bug 32562 - [V8] Generate trivial named property getters.
Summary: [V8] Generate trivial named property getters.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 32455
  Show dependency tree / graph
 
Reported: 2009-12-15 09:04 PST by Dimitri Glazkov (Google)
Modified: 2009-12-15 11:56 PST (History)
4 users (show)

See Also:

Attachments
Generate trivial named property getters, v1. (4.80 KB, patch)
2009-12-15 09:09 PST, Dimitri Glazkov (Google) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-12-15 09:04:38 PST 
This is essentially a mirror patch to the one on bug 32455, only for named property getters. Small steps.
Comment 1 Dimitri Glazkov (Google) 2009-12-15 09:09:12 PST 
Created attachment 44881 [details]
Generate trivial named property getters, v1.
Comment 2 WebKit Review Bot 2009-12-15 09:12:15 PST 
style-queue ran check-webkit-style on attachment 44881 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-15 11:22:35 PST 
Comment on attachment 44881 [details]
Generate trivial named property getters, v1.

toAtomicWebCoreStringWithNullCheck is the only confusing part.  Looks good though!
Comment 4 Jens Alfke 2009-12-15 11:35:53 PST 
Looks good.
Comment 5 Dimitri Glazkov (Google) 2009-12-15 11:56:03 PST 
Landed as http://trac.webkit.org/changeset/52166.