Bug 32560 - [GTK] display FPS stats for video element
Summary: [GTK] display FPS stats for video element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-15 07:21 PST by Philippe Normand
Modified: 2009-12-17 06:28 PST (History)
1 user (show)

See Also:


Attachments
display FPS statistics if WEBKIT_DEBUG environment variable is set. (3.93 KB, patch)
2009-12-15 07:25 PST, Philippe Normand
xan.lopez: review+
xan.lopez: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2009-12-15 07:21:57 PST
It can sometimes be useful to display video FPS statistics when debugging. Setting WEBKIT_DEBUG to Media should enable this feature, stats would be displayed on the video.
Comment 1 Philippe Normand 2009-12-15 07:25:34 PST
Created attachment 44877 [details]
display FPS statistics if WEBKIT_DEBUG environment variable is set.
Comment 2 WebKit Review Bot 2009-12-15 07:30:23 PST
Attachment 44877 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:924:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:926:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:929:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:933:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 4
Comment 3 Xan Lopez 2009-12-17 04:33:45 PST
Comment on attachment 44877 [details]
display FPS statistics if WEBKIT_DEBUG environment variable is set.

r=me
Comment 4 Philippe Normand 2009-12-17 06:28:55 PST
Landed as r52251