Bug 32548 - Allow custom memory allocation control for FormElementKey class
Summary: Allow custom memory allocation control for FormElementKey class
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-15 04:20 PST by Zoltan Horvath
Modified: 2009-12-15 10:23 PST (History)
1 user (show)

See Also:

Attachments
proposed patch (1.04 KB, patch)
2009-12-15 04:21 PST, Zoltan Horvath 		darin: review-
zoltan: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-12-15 04:20:08 PST 
Inherits FormElementKey from FastAllocBase because it is instantiated by  'new' at: WebCore/dom/Document.h:170.
Comment 1 Zoltan Horvath 2009-12-15 04:21:01 PST 
Created attachment 44863 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-15 04:24:19 PST 
style-queue ran check-webkit-style on attachment 44863 [details] without any errors.
Comment 3 Darin Adler 2009-12-15 08:23:00 PST 
Comment on attachment 44863 [details]
proposed patch

The call to new in Document.h is a placement new, not a memory allocation new. I believe the static analyzer got it wrong.
Comment 4 Zoltan Horvath 2009-12-15 10:23:13 PST 
Yes. I have to modify the analyzing rule a little bit. 

This bug is invalid.