Bug 32547 - Allow custom memory allocation control for WeakGCMap classes
Summary: Allow custom memory allocation control for WeakGCMap classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-15 04:00 PST by Zoltan Horvath
Modified: 2009-12-15 13:55 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (1.20 KB, patch)
2009-12-15 04:06 PST, Zoltan Horvath 		darin: review-
Details | Formatted Diff | Diff
updated to FastAllocBase (1.17 KB, patch)
2009-12-15 10:34 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-12-15 04:00:57 PST 
Inherits WeakGCMap from Noncopyable because it is instantiated by 'new' at: WebCore/dom/Document.cpp:512 and don't need to be copyable.
Comment 1 Zoltan Horvath 2009-12-15 04:06:21 PST 
Created attachment 44861 [details]
proposed patch
Comment 2 WebKit Review Bot 2009-12-15 04:08:37 PST 
style-queue ran check-webkit-style on attachment 44861 [details] without any errors.
Comment 3 Darin Adler 2009-12-15 08:30:05 PST 
Comment on attachment 44861 [details]
proposed patch

HashMap is copyable, so I’m not sure why we would treat this as noncopyable. Please use FastAllocBase instead.
Comment 4 Zoltan Horvath 2009-12-15 10:34:08 PST 
Created attachment 44887 [details]
updated to FastAllocBase

I chose Noncopyable because it is copied nowhere now, okay I filed the FastAllocBase-d version!
Comment 5 WebKit Review Bot 2009-12-15 10:34:50 PST 
style-queue ran check-webkit-style on attachment 44887 [details] without any errors.
Comment 6 WebKit Commit Bot 2009-12-15 13:55:15 PST 
Comment on attachment 44887 [details]
updated to FastAllocBase

Clearing flags on attachment: 44887

Committed r52171: <http://trac.webkit.org/changeset/52171>
Comment 7 WebKit Commit Bot 2009-12-15 13:55:19 PST 
All reviewed patches have been landed.  Closing bug.