WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
32531
Move Credential handling out into a separate module
https://bugs.webkit.org/show_bug.cgi?id=32531
Summary
Move Credential handling out into a separate module
Eric Seidel (no email)
Reported
2009-12-14 15:43:08 PST
Move Credential handling out into a separate module bugzilla.py does too much. Lets start by moving credential handling out into its own module. It was already some static functions (which made it harder to test too).
Attachments
Patch
(13.90 KB, patch)
2009-12-14 15:46 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-12-14 15:46:57 PST
Created
attachment 44826
[details]
Patch
WebKit Review Bot
Comment 2
2009-12-14 21:04:55 PST
style-queue ran check-webkit-style on
attachment 44826
[details]
without any errors.
Adam Barth
Comment 3
2009-12-14 21:46:36 PST
Comment on
attachment 44826
[details]
Patch This looks great. Love the tests. However, we should normalize to using _ before private member variable names. :)
WebKit Commit Bot
Comment 4
2009-12-14 22:01:02 PST
Comment on
attachment 44826
[details]
Patch Clearing flags on attachment: 44826 Committed
r52135
: <
http://trac.webkit.org/changeset/52135
>
WebKit Commit Bot
Comment 5
2009-12-14 22:01:08 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug