Bug 32531 - Move Credential handling out into a separate module
Summary: Move Credential handling out into a separate module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-14 15:43 PST by Eric Seidel (no email)
Modified: 2009-12-14 22:01 PST (History)
3 users (show)

See Also:

Attachments
Patch (13.90 KB, patch)
2009-12-14 15:46 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-12-14 15:43:08 PST 
Move Credential handling out into a separate module

bugzilla.py does too much.  Lets start by moving credential handling out into its own module.  It was already some static functions (which made it harder to test too).
Comment 1 Eric Seidel (no email) 2009-12-14 15:46:57 PST 
Created attachment 44826 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-14 21:04:55 PST 
style-queue ran check-webkit-style on attachment 44826 [details] without any errors.
Comment 3 Adam Barth 2009-12-14 21:46:36 PST 
Comment on attachment 44826 [details]
Patch

This looks great.  Love the tests.  However, we should normalize to using _ before private member variable names.  :)
Comment 4 WebKit Commit Bot 2009-12-14 22:01:02 PST 
Comment on attachment 44826 [details]
Patch

Clearing flags on attachment: 44826

Committed r52135: <http://trac.webkit.org/changeset/52135>
Comment 5 WebKit Commit Bot 2009-12-14 22:01:08 PST 
All reviewed patches have been landed.  Closing bug.