Bug 32508 - [website] Add more information to contributing code page: associate bug report, file size limit, etc
Summary: [website] Add more information to contributing code page: associate bug repor...
Status: RESOLVED DUPLICATE of bug 32542
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P4 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-14 03:52 PST by Chris Jerdonek
Modified: 2009-12-19 21:56 PST (History)
1 user (show)

See Also:


Attachments
Proposed patch (83.12 KB, patch)
2009-12-14 04:29 PST, Chris Jerdonek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2009-12-14 03:52:36 PST
This is a report to add more information to the "contributing" code page:

http://webkit.org/coding/contributing.html

For example--

* Add that every contribution must be associated to a bug report.
  In particular, it may be necessary for the contributor to create 
  a new bug report for the contribution he or she is working on.
* Add images to the section about submitting a patch since my 
  understanding is that this task is somewhat confusing for new 
  contributors.
* Add that patches should normally be less than 20K.

(cf. https://bugs.webkit.org/show_bug.cgi?id=25877 for the last two points)

This report is related to a bug report about the life cycle page, letting people know you are working on an issue, setting the assignees, etc:

https://bugs.webkit.org/show_bug.cgi?id=32494
Comment 1 Chris Jerdonek 2009-12-14 04:29:56 PST
Created attachment 44786 [details]
Proposed patch

Note that this patch also addresses a couple issues from 32494:

https://bugs.webkit.org/show_bug.cgi?id=32494

I am submitting this patch first to keep the patch for 32494 smaller.

Question: is it necessary to create a new report for multiple patches on the same issue, or is it okay to land more than one patch from the same bug report (for example to spread a contribution over multiple patches to keep each patch file size down)?
Comment 2 Chris Jerdonek 2009-12-19 21:56:35 PST
This has been split into three reports:

https://bugs.webkit.org/show_bug.cgi?id=32542 (submitting patches for review)

https://bugs.webkit.org/show_bug.cgi?id=32579 (patch size)

https://bugs.webkit.org/show_bug.cgi?id=32781 (bug life cycle)

*** This bug has been marked as a duplicate of bug 32542 ***