Bug 32496 - Switch remaining cases of string construction to use StringBuilder.
Summary: Switch remaining cases of string construction to use StringBuilder.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-13 14:18 PST by Gavin Barraclough
Modified: 2009-12-28 23:38 PST (History)
2 users (show)

See Also:


Attachments
The patch (28.50 KB, patch)
2009-12-13 14:26 PST, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2009-12-13 14:18:18 PST
Builds strings using a vector rather than using string append / addition.
Comment 1 Gavin Barraclough 2009-12-13 14:26:15 PST
Created attachment 44765 [details]
The patch

~0% performance impact (possible slight, slight progression)
Comment 2 WebKit Review Bot 2009-12-13 14:31:22 PST
style-queue ran check-webkit-style on attachment 44765 [details] without any errors.
Comment 3 Sam Weinig 2009-12-13 14:44:35 PST
Comment on attachment 44765 [details]
The patch

> Index: JavaScriptCore/runtime/StringBuilder.h
> ===================================================================
> --- JavaScriptCore/runtime/StringBuilder.h	(revision 0)
> +++ JavaScriptCore/runtime/StringBuilder.h	(revision 0)
> @@ -0,0 +1,64 @@
> +/*

...

> +    }
> +};
> +
> +};

This ; is not necessary.
Comment 4 Eric Seidel (no email) 2009-12-28 23:38:42 PST
Looks like this was landed as r52075.  Closing.