In FF3.5, IE7 and Safari 4, the text it not clipped in this test case. In nightlies the first line of text is clipped.
The offending HTML:
<span style="background-color: white; font-size: 20px;">
<span style="font-size: small; ">FOOBARBAZ<br>BAZBARFOO</span></span>
Marking P1 as it's a regression.
Caused by <http://trac.webkit.org/changeset/47440>.
(In reply to comment #3)
> Caused by <http://trac.webkit.org/changeset/47440>.
Specifically, this part:
“Significant changes have been made to the "almost strict mode" line box quirk where objects with no
text children have no effect on the height of a line. Instead of making the height() of the objects
variable and dependent on overflow, the objects now have their full height and get placed on
the baseline properly. They simply don't contribute to overflow above lineTop/Bottom.”
Since the box is full height, it paints the background through the entire height.
Hyatt, do you have any ideas how to fix this?
Created attachment 46493 [details]
Created attachment 46495 [details]
The code in paintBoxDecorations and paintMask looks suspiciously similar. Is there a reason not to put it in a helper function? It would make the code more readable to and constrain the quirk to one place in the code.
Comment on attachment 46495 [details]
r=me (with updated test)
Fixed in r53200.