Bug 32491 - [Qt] The test tst_QWebPage::inputMethods(QWebView) fails
Summary: [Qt] The test tst_QWebPage::inputMethods(QWebView) fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Qt
Depends on:
Blocks: 32216
  Show dependency treegraph
 
Reported: 2009-12-13 10:29 PST by Benjamin Poulain
Modified: 2009-12-14 12:35 PST (History)
4 users (show)

See Also:


Attachments
Update the test to expect the correct behavior (1.67 KB, patch)
2009-12-14 06:40 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Update the test to expect the correct behavior (1.67 KB, patch)
2009-12-14 06:41 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2009-12-13 10:29:47 PST
The autotest tst_QWebPage::inputMethods(QWebView) is failing:

FAIL!  : tst_QWebPage::inputMethods(QWebView) Compared values are not the same
   Actual (QString("-webkit-serif")): -webkit-serif
   Expected (font.family()): Times New Roman
   Loc: [/home/ikipou/dev/webkit/qtwebkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1411)]
FAIL!  : tst_QWebPage::inputMethods(QGraphicsWebView) Compared values are not the same
   Actual (QString("-webkit-serif")): -webkit-serif
   Expected (font.family()): Times New Roman
   Loc: [/home/ikipou/dev/webkit/qtwebkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1411)]
Comment 1 Andreas Kling 2009-12-14 06:40:12 PST
Created attachment 44792 [details]
Update the test to expect the correct behavior
Comment 2 Andreas Kling 2009-12-14 06:41:32 PST
Created attachment 44793 [details]
Update the test to expect the correct behavior

Same patch with a minor tweak to the changelog entry.
Comment 3 WebKit Review Bot 2009-12-14 06:48:46 PST
style-queue ran check-webkit-style on attachment 44793 [details] without any errors.
Comment 4 Simon Hausmann 2009-12-14 08:26:46 PST
Comment on attachment 44793 [details]
Update the test to expect the correct behavior

r=me, thanks!
Comment 5 WebKit Commit Bot 2009-12-14 12:35:39 PST
Comment on attachment 44793 [details]
Update the test to expect the correct behavior

Clearing flags on attachment: 44793

Committed r52110: <http://trac.webkit.org/changeset/52110>
Comment 6 WebKit Commit Bot 2009-12-14 12:35:44 PST
All reviewed patches have been landed.  Closing bug.