Bug 32468 - [bzt] Add AbstractPatchSequencingCommand to remove redundant code
Summary: [bzt] Add AbstractPatchSequencingCommand to remove redundant code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 32467
Blocks: 32469
  Show dependency tree / graph
 
Reported: 2009-12-12 01:32 PST by Adam Barth
Modified: 2009-12-14 21:38 PST (History)
1 user (show)

See Also:

Attachments
Patch (7.60 KB, patch)
2009-12-12 01:33 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-12 01:32:46 PST 
Redundant code is bad.  This patch moves us towards more declarative commands.
Comment 1 Adam Barth 2009-12-12 01:33:45 PST 
Created attachment 44735 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-12-14 16:23:10 PST 
Comment on attachment 44735 [details]
Patch

I'm confused by this line:
 126         return step_sequence, step_sequence.options()
Comment 3 Eric Seidel (no email) 2009-12-14 21:22:24 PST 
Comment on attachment 44735 [details]
Patch

So I don't understand why options need to be returned separately from the sequence, but otherwise this looks fine.

We really need to kill all these "show_in_main_help = false" at some point.
Comment 4 Adam Barth 2009-12-14 21:37:51 PST 
Good point.  I'll fix that at the end.
Comment 5 Adam Barth 2009-12-14 21:38:18 PST 
Comment on attachment 44735 [details]
Patch

Clearing flags on attachment: 44735

Committed r52132: <http://trac.webkit.org/changeset/52132>
Comment 6 Adam Barth 2009-12-14 21:38:24 PST 
All reviewed patches have been landed.  Closing bug.