Bug 32464 - [bzt] Kill LandingSequence
Summary: [bzt] Kill LandingSequence
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 32406 32467
  Show dependency treegraph
Reported: 2009-12-11 23:45 PST by Adam Barth
Modified: 2009-12-14 21:21 PST (History)
2 users (show)

See Also:

Patch (28.02 KB, patch)
2009-12-11 23:47 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-12-11 23:45:46 PST
It's dead Jim.
Comment 1 Adam Barth 2009-12-11 23:47:01 PST
Created attachment 44728 [details]
Comment 2 WebKit Review Bot 2009-12-11 23:57:00 PST
style-queue ran check-webkit-style on attachment 44728 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-14 16:17:43 PST
Comment on attachment 44728 [details]

Now we'll need to test the input/output state of each command.  Seems this would be easier to test if they were in fact exactly that.  input = {} and output = {}.  Do we ever need output to persist across comamnds?  e.g. that command1 produces output that command3 uses, but command2 ignores?  Donno.

 196         state = {"patch": patch}

I would have put spaces after { and before }... but maybe the PEP says something here?  Also I would have put a space before :

Seems like Command should expose a run_and_handle_errors method, which calls through to the _sequence method.

Looks OK though.  Would be good to figure out what the official spacing is supposed to be, since your spacing here is inconsistent with at least the code that I have written in modules/*.py
Comment 4 Adam Barth 2009-12-14 21:21:08 PST
Ok.  I'll fix the spacing thing at the end.  It's going to conflict otherwise.  We discussed the input/output thing in person.  That's to make the steps more loosely coupled.
Comment 5 Adam Barth 2009-12-14 21:21:41 PST
Comment on attachment 44728 [details]

Clearing flags on attachment: 44728

Committed r52129: <http://trac.webkit.org/changeset/52129>
Comment 6 Adam Barth 2009-12-14 21:21:46 PST
All reviewed patches have been landed.  Closing bug.