Bug 32462 - build-webkit: Add --inspector-frontend flag to copy inspector front-end changes to the built framework
Summary: build-webkit: Add --inspector-frontend flag to copy inspector front-end chang...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
Depends on:
Reported: 2009-12-11 23:23 PST by Daniel Bates
Modified: 2009-12-19 12:53 PST (History)
9 users (show)

See Also:

Patch (4.53 KB, patch)
2009-12-11 23:45 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (4.52 KB, patch)
2009-12-12 13:31 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2009-12-11 23:23:27 PST
We should make inspector development more consistent with the rest of WebKit development.

Currently, any changes that are made to the front-end inspector files must be manually copied over to the built WebCore framework in order to test the changes. Instead, we should have a flag, say --inspector-frontend, that will do this. Moreover, build-webkit should be smart enough to know which front-end files have changed so that we don't have to copy over all the front-end files.
Comment 1 Timothy Hatcher 2009-12-11 23:26:10 PST
Note building with Xcode works fine.
Comment 2 Daniel Bates 2009-12-11 23:45:29 PST
Created attachment 44726 [details]

Briefly read through the Qt and GTK build files, but I am unclear what the default installation directory for the inspector front-end files is for the Qt and GTK builds. In particular for the Windows platform. For reference, on my Ubuntu Qt build it defaults to /usr/share.  I'll try reading through these files again. Does anybody know offhand?
Comment 3 Daniel Bates 2009-12-12 13:31:50 PST
Created attachment 44742 [details]

Minor stylistic change. Changed ordering of variables $sourceInspectorPath and $inspectorResourcesDirPath in subroutine copyInspectorFrontendFiles.

Spoke to Timothy on IRC, and this patch should be sufficient to land. That is, the assumptions for the Qt and GTK builds are not unreasonable. Optionally, the user can set the environment variable WebKitInspectorResourcesDir to specify where the built inspector front-end files are located.
Comment 4 WebKit Review Bot 2009-12-12 13:33:47 PST
style-queue ran check-webkit-style on attachment 44742 [details] without any errors.
Comment 5 WebKit Commit Bot 2009-12-19 12:53:27 PST
Comment on attachment 44742 [details]

Clearing flags on attachment: 44742

Committed r52393: <http://trac.webkit.org/changeset/52393>
Comment 6 WebKit Commit Bot 2009-12-19 12:53:34 PST
All reviewed patches have been landed.  Closing bug.