Bug 3246 - HSPACE and VSPACE attributes are ignored in APPLET element
Summary: HSPACE and VSPACE attributes are ignored in APPLET element
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 412
Hardware: All All
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-01 16:16 PDT by Dave Hyatt
Modified: 2005-07-13 23:10 PDT (History)
0 users

See Also:

Attachments
test cases (16.67 KB, application/zip)
2005-06-15 00:57 PDT, Toby Peterson 		no flags Details
Add support for HSPACE and VSPACE on APPLET (1.20 KB, patch)
2005-06-15 02:18 PDT, Niels Leenheer (HTML5test) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2005-06-01 16:16:18 PDT 
4/26/05 11:17 AM Chris Petersen:
* SUMMARY
Both VSPACE and HSPACE attributes are ignored when used in a APPLET element
* STEPS TO REPRODUCE
1. Launch Safari 2.0 (v412) under Tiger 8A428 (Java enabled)
2. Open test case "vspace_applet.html" in Safari.
3. Notice the first APPLET has a VSPACE value of  "100" pixels but no whitespace is rendered above or 
below this applet.
4. Open this same test case in Firefox. Notice whitespace is rendered above and below the FIRST applet.
5.  Open test case "hspace_applet.html" in Safari.
6. Notice the first APPLET has a HSPACE  value of "100" pixels but no whitespace is rendered on either 
side of the applet.
7. Open this same test case in Firefox. Notice whitespace is rendered on left and right side of the FIRST 
applet.


* REGRESSION
No, these attributes were not supported by Safari 1.2 either
* NOTES
We need to support these attributes when used with a APPLET element. I have attached a .zip file that 
contains hspace_applet.html, vspace_applet.html, and applet code.
Comment 1 Dave Hyatt 2005-06-01 16:16:43 PDT 
Apple Bug: rdar://4099440/
Comment 2 Toby Peterson 2005-06-15 00:57:50 PDT 
Created attachment 2350 [details]
test cases
Comment 3 Niels Leenheer (HTML5test) 2005-06-15 02:18:46 PDT 
Created attachment 2354 [details]
Add support for HSPACE and VSPACE on APPLET

This patch adds support for the HSPACE and VSPACE attributes on the APPLET
element.
Comment 4 Joost de Valk (AlthA) 2005-06-15 02:23:20 PDT 
patch works for me.
Comment 5 Darin Adler 2005-06-18 16:55:01 PDT 
Comment on attachment 2354 [details]
Add support for HSPACE and VSPACE on APPLET

Although Dave Hyatt and I discussed better factoring of this code, it seems
fine to add this now and worry further about factoring later.

r=me
Comment 6 Chris Petersen 2005-06-18 21:44:39 PDT 
Excellent ! Verified fixed with latest TOT Webkit (06/18). Tested under 10.4.1 (B15).
Comment 7 Joost de Valk (AlthA) 2005-07-13 23:02:57 PDT 
Fixed in 10.4.2