Bug 32456 - Errors in WebGL[T]Array set() and get() methods
Summary: Errors in WebGL[T]Array set() and get() methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-11 19:20 PST by Kenneth Russell
Modified: 2009-12-12 19:02 PST (History)
6 users (show)

See Also:

Attachments
Patch (13.48 KB, patch)
2009-12-12 00:41 PST, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2009-12-11 19:20:18 PST 
The explicit get() method defined in WebGLFloatArray.idl should return float, not long.
Comment 1 Kenneth Russell 2009-12-11 22:49:04 PST 
The set() method's documentation taking a single value is also incorrect, and the implementation rounds the incoming value to an integer.
Comment 2 Kenneth Russell 2009-12-12 00:35:18 PST 
Two additional issues:
 - The JS bindings for most of the arrays' set(index, value) methods were truncating the value to signed char.
 - The IDL for WebGLUnsignedIntArray.get() needed to return unsigned long rather than long.
Comment 3 Kenneth Russell 2009-12-12 00:41:43 PST 
Created attachment 44730 [details]
Patch
Comment 4 Oliver Hunt 2009-12-12 18:54:00 PST 
Comment on attachment 44730 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2009-12-12 19:02:22 PST 
Comment on attachment 44730 [details]
Patch

Clearing flags on attachment: 44730

Committed r52058: <http://trac.webkit.org/changeset/52058>
Comment 6 WebKit Commit Bot 2009-12-12 19:02:27 PST 
All reviewed patches have been landed.  Closing bug.