WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 32453
Web Inspector: Replace split pane with tabbed pane in resource contents view.
https://bugs.webkit.org/show_bug.cgi?id=32453
Summary
Web Inspector: Replace split pane with tabbed pane in resource contents view.
Pavel Feldman
Reported
2009-12-11 14:59:41 PST
Created
attachment 44711
[details]
[IMAGE] Mock When resource is selected in the Resources Panel, it should show tabbed pane to the right with following tabs: - HTTP Info - Contents (anything else?). I'll need tabs design for this.
Attachments
[IMAGE] Mock
(142.48 KB, image/png)
2009-12-11 14:59 PST
,
Pavel Feldman
no flags
Details
[IMAGE] Patch renders it like this.
(156.05 KB, image/png)
2010-01-24 14:25 PST
,
Pavel Feldman
no flags
Details
[PATCH] Proposed change.
(17.02 KB, patch)
2010-01-24 14:28 PST
,
Pavel Feldman
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2010-01-24 14:25:55 PST
Created
attachment 47300
[details]
[IMAGE] Patch renders it like this. I am doing this since it simplifies migration to SourceFrame2 (which only works well with absolute positioning). I'll submit a patch shortly that renders tabs like in this image. Good design for tabs is appreciated. Btw, at some point we should optimize it a way that we only load source when content tab is switched on.
Pavel Feldman
Comment 2
2010-01-24 14:28:54 PST
Created
attachment 47301
[details]
[PATCH] Proposed change.
Timothy Hatcher
Comment 3
2010-01-24 14:45:34 PST
Comment on
attachment 47301
[details]
[PATCH] Proposed change.
> + this.tabsElement.className = "scope-bar";
I don't think reusing scope-bar is good. I'm not fond of the recessed tab look. But it is fine for now.
Pavel Feldman
Comment 4
2010-01-25 02:38:34 PST
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/ResourceView.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/ScriptsPanel.js M WebCore/inspector/front-end/Settings.js M WebCore/inspector/front-end/SourceFrame.js M WebCore/inspector/front-end/SourceView.js M WebCore/inspector/front-end/inspector.css Committed
r53794
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug