Bug 32447 – Content in <iframe> doesn't appear when going back to http://webkit.org/blog/386/3d-transforms/

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Adam Roben (:aroben)]

To reproduce:

1. Go to http://webkit.org/blog/386/3d-transforms/
2. Go to some other page
3. Click the Back button

The <iframe>'s content (which appears in the upper-left corner due to bug 32446) doesn't appear.

<rdar://problem/7465609>

[Simon Fraser (smfr)]

*** Bug 44698 has been marked as a duplicate of this bug. ***

[Chris Marrin]

Created attachment 71507 [details]
Patch

[Dean Jackson]

Comment on attachment 71507 [details]
Patch

Couldn't you make the manual test show success or failure? You're just printing the layerTree into a <pre>, but you could actually look at the text to say "PASS" or "FAIL".

[Chris Marrin]

(In reply to comment #4)
> (From update of attachment 71507 [details])
> Couldn't you make the manual test show success or failure? You're just printing the layerTree into a <pre>, but you could actually look at the text to say "PASS" or "FAIL".

Remember this is not a layout test. There's no way for me to know if the image is showing up. I can't do layerAsText() unless I'm in DRT and the bug doesn't happen there. So I don't know of any way short of visual inspection to determine if the bug is fixed.

[Adam Roben (:aroben)]

Comment on attachment 71507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71507&action=review

> WebCore/ChangeLog:14
> +        There is no layout test, but I added a manual test. This test is ready to be a layout test
> +        but I could not get the queueBackNavigation/queueForwardNavigation functions in
> +        LayoutTestController to behave like manually hitting the forward/back buttons, so the
> +        failure didn't occur. 

DRT doesn't have the back/forward cache enabled. Maybe that's the problem?

[Adam Roben (:aroben)]

Comment on attachment 71507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71507&action=review

> WebCore/manual-tests/compositing/show-composited-iframe-on-back-button.html:10
> +    <!--
> +        This content was originally intended as a layout test, but the sequencing performed by 
> +        queueBackNavigation/queueForwardNavigation differs somehow from what occurs when hitting 
> +        the back and forward buttons, so the error does not occur. I've left all the LayoutTestController 
> +        logic in the test in case this is fixed in the future.
> +    -->

I think you should add a comment about DRT's back/forward cache being disabled. Maybe these days we have a way to enable it for certain tests?

[Chris Marrin]

Landed in http://trac.webkit.org/changeset/70321

[Simon Fraser (smfr)]

*** Bug 29361 has been marked as a duplicate of this bug. ***